Move testTracer struct in tracingtest package and reuse it #3322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 25, 2024 13:36
Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
AlexanderYastrebov
requested changes
Nov 25, 2024
…shed spans Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
RomanZavodskikh
force-pushed
the
refactorMockTracer
branch
from
98e895d to
4738392
Compare
Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
|
👍 |
AlexanderYastrebov
requested review from
AlexanderYastrebov
and removed request for
AlexanderYastrebov
AlexanderYastrebov
approved these changes
Nov 26, 2024
|
👍 |
MustafaSaber
reviewed
Dec 5, 2024
This was referenced Dec 5, 2024
MustafaSaber
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Dec 9, 2024
* zalando/skipper#3271 * zalando/skipper#3283 * zalando/skipper#3284 * zalando/skipper#3285 * zalando/skipper#3281 * zalando/skipper#3282 * zalando/skipper#3294 * zalando/skipper#3293 * zalando/skipper#3292 * zalando/skipper#3291 * zalando/skipper#3288 * zalando/skipper#3300 * zalando/skipper#3301 * zalando/skipper#3290 * zalando/skipper#3328 * zalando/skipper#3319 * zalando/skipper#3325 * zalando/skipper#3310 * zalando/skipper#3307 * zalando/skipper#3322 * zalando/skipper#3326 * zalando/skipper#3289 zalando/skipper@v0.21.220...v0.21.224 follow up on #8574 Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
MustafaSaber
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Dec 9, 2024
* zalando/skipper#3271 * zalando/skipper#3283 * zalando/skipper#3284 * zalando/skipper#3285 * zalando/skipper#3281 * zalando/skipper#3282 * zalando/skipper#3294 * zalando/skipper#3293 * zalando/skipper#3292 * zalando/skipper#3291 * zalando/skipper#3288 * zalando/skipper#3300 * zalando/skipper#3301 * zalando/skipper#3290 * zalando/skipper#3328 * zalando/skipper#3319 * zalando/skipper#3325 * zalando/skipper#3310 * zalando/skipper#3307 * zalando/skipper#3322 * zalando/skipper#3326 * zalando/skipper#3289 zalando/skipper@v0.21.220...v0.21.224 follow up on #8574 Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
MustafaSaber
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Dec 9, 2024
* zalando/skipper#3271 * zalando/skipper#3283 * zalando/skipper#3284 * zalando/skipper#3285 * zalando/skipper#3281 * zalando/skipper#3282 * zalando/skipper#3294 * zalando/skipper#3293 * zalando/skipper#3292 * zalando/skipper#3291 * zalando/skipper#3288 * zalando/skipper#3300 * zalando/skipper#3301 * zalando/skipper#3290 * zalando/skipper#3328 * zalando/skipper#3319 * zalando/skipper#3325 * zalando/skipper#3310 * zalando/skipper#3307 * zalando/skipper#3322 * zalando/skipper#3326 * zalando/skipper#3289 zalando/skipper@v0.21.220...v0.21.224 follow up on #8574 Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
MustafaSaber
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Dec 9, 2024
* zalando/skipper#3271 * zalando/skipper#3283 * zalando/skipper#3284 * zalando/skipper#3285 * zalando/skipper#3281 * zalando/skipper#3282 * zalando/skipper#3294 * zalando/skipper#3293 * zalando/skipper#3292 * zalando/skipper#3291 * zalando/skipper#3288 * zalando/skipper#3300 * zalando/skipper#3301 * zalando/skipper#3290 * zalando/skipper#3328 * zalando/skipper#3319 * zalando/skipper#3325 * zalando/skipper#3310 * zalando/skipper#3307 * zalando/skipper#3322 * zalando/skipper#3326 * zalando/skipper#3289 zalando/skipper@v0.21.220...v0.21.224 follow up on #8574 Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests is split from #3318 to refactor change of testTracer to make it more reusable.