Build lightstep image based on alpine #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkeloscar
force-pushed
the
lightstep-alpine
branch
from
516b30e
to
0582aa4
Compare
|
Does this work on your machine? |
mikkeloscar
force-pushed
the
lightstep-alpine
branch
3 times, most recently
from
d874809
to
e0c05c6
Compare
mikkeloscar
changed the title
|
@szuecs pushed some changes and updated the PR description. |
mikkeloscar
force-pushed
the
lightstep-alpine
branch
from
e0c05c6
to
81e25be
Compare
Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
mikkeloscar
force-pushed
the
lightstep-alpine
branch
from
81e25be
to
d1096cf
Compare
|
@mikkeloscar can you start the docker container without errors raised on plugin load time? |
|
@szuecs yes. I believe this means it's loaded right? $ docker run registry.opensource.zalan.do/pathfinder/skipper-lightstep-test:pr-762-9
[APP]time="2018-09-01T12:57:36Z" level=info msg="found plugin tracing_lightstep at plugins/tracing_lightstep.so"
[APP]time="2018-09-01T12:57:36Z" level=info msg="found plugin tracing_lightstep at /plugins/tracing_lightstep.so"
[APP]time="2018-09-01T12:57:36Z" level=info msg="attempting to load plugin from /plugins/tracing_lightstep.so"
[APP]time="2018-09-01T12:57:36Z" level=warning msg="no route source specified"
[APP]time="2018-09-01T12:57:36Z" level=info msg="Expose metrics in codahale format"
[APP]time="2018-09-01T12:57:36Z" level=info msg="support listener on :9911"
[APP]time="2018-09-01T12:57:36Z" level=info msg="proxy listener on :9090"
[APP]time="2018-09-01T12:57:36Z" level=info msg="certPathTLS or keyPathTLS not found, defaulting to HTTP"
# validate that we are running alpine
$ docker run --entrypoint /bin/sh registry.opensource.zalan.do/pathfinder/skipper-lightstep-test:pr-762-9 -c "cat /etc/issue"
Welcome to Alpine Linux 3.8
Kernel \r on an \m (\l) |
|
👍 |
Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
This was already done by @arjunrn. But I now just removed the variables no longer needed. The image I tested and showed the logs from was build via CDP :) |
|
👍 |
1 similar comment
|
👍 |
|
Thanks @mikkeloscar! |
AlexanderYastrebov
added a commit
that referenced
this pull request
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build lightstep image based on alpine. This is done to reduce the image size. It's a reduction from
179MB->45.6MBcompared to the ubuntu based image.It's implemented by adding new make targets
alpine.buildandalpine.pluginsthat builds skipper and plugins in agolang:alpinebased image such that both skipper and the tracing plugin is linked againstmuslinstead oflibc.Ref: #761