Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the lightstep image with ubuntu base image. #761

Merged
merged 1 commit into from
Aug 31, 2018

Conversation

arjunrn
Copy link
Contributor

@arjunrn arjunrn commented Aug 30, 2018

The lightstep image needs libc to load plugins which is missing from the standard skipper Docker image. This PR changes the dockerfile to use a ubuntu base image.

Signed-off-by: Arjun Naik <arjun.naik@zalando.de>
@arjunrn arjunrn requested a review from szuecs August 30, 2018 20:05
@mikkeloscar
Copy link
Member

I would assume it only needs libc because it's being linked against it on the Ubuntu build VM. If we instead build it in a multistage alpine based Dockerfile, then we can keep using the smaller alpine image.

@arjunrn
Copy link
Contributor Author

arjunrn commented Aug 31, 2018

@mikkeloscar Already tried something like that, didn't work. I believe that the go plugins need to be build with CGO_ENABLED=1 and then the plugins are loaded by the main skipper binary and this steps needs some(not all) libraries installed. These libraries are not present on the standard alpine image. The other option is to extend the alpine image with only the libraries needed by the skipper binary but I'm not sure about this. @szuecs maybe you have some suggestions.

Copy link
Member

@szuecs szuecs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's test it with ubuntu and we can try the approach mikkel suggests to make it better if this works

@szuecs
Copy link
Member

szuecs commented Aug 31, 2018

👍

@arjunrn
Copy link
Contributor Author

arjunrn commented Aug 31, 2018

@mikkeloscar Here's the issue which describes the problem.

@arjunrn
Copy link
Contributor Author

arjunrn commented Aug 31, 2018

👍

@arjunrn arjunrn merged commit 5d7ae30 into master Aug 31, 2018
@arjunrn arjunrn deleted the build-lightstep-ubuntu branch August 31, 2018 08:25
@mikkeloscar
Copy link
Member

@arjunrn @szuecs fine from my side 👍 I might take a look at using alpine, because I'm interested in how the pluginsin go work anyway. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants