Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(frontend): update cml test script to ignore flaky tests #537

Merged

Conversation

RomanBredehoft
Copy link
Contributor

Now, you should not stumble on any flaky tests from our side

@cla-bot cla-bot bot added the cla-signed label Aug 4, 2023
@BourgerieQuentin
Copy link
Member

@slab-ci ml-tests

@slab-ci
Copy link

slab-ci bot commented Aug 4, 2023

Failed to run command: command 'ml-tests' not found in config file

@BourgerieQuentin
Copy link
Member

@slab-ci ml-test

ci/scripts/test_cml.sh Outdated Show resolved Hide resolved
@RomanBredehoft RomanBredehoft force-pushed the chore(frontend)/update_cml_test_script_with_no_flaky branch 2 times, most recently from 534094b to 53d5155 Compare August 4, 2023 13:00
@RomanBredehoft
Copy link
Contributor Author

@slab-ci ml-test

@RomanBredehoft RomanBredehoft force-pushed the chore(frontend)/update_cml_test_script_with_no_flaky branch 2 times, most recently from b33588a to cb491d8 Compare August 4, 2023 15:14
@RomanBredehoft
Copy link
Contributor Author

@slab-ci ml-test

@RomanBredehoft
Copy link
Contributor Author

collecting the test itself seems to be enough to trigger the flaky error ... normally this should be fixed by zama-ai/concrete-ml#133 and hopefully the script is going to work well after that 🤞

@bcm-at-zama
Copy link
Contributor

Thx, I approved if it needs to be merged urgently

@RomanBredehoft RomanBredehoft force-pushed the chore(frontend)/update_cml_test_script_with_no_flaky branch from cb491d8 to 5217169 Compare August 4, 2023 16:52
@RomanBredehoft
Copy link
Contributor Author

hopefully now it works !

@RomanBredehoft
Copy link
Contributor Author

@slab-ci ml-test

@BourgerieQuentin BourgerieQuentin merged commit fa66f99 into main Aug 7, 2023
@BourgerieQuentin BourgerieQuentin deleted the chore(frontend)/update_cml_test_script_with_no_flaky branch August 7, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants