Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(frontend): update cml test script to ignore flaky tests #537

Merged
merged 1 commit into from
Aug 7, 2023
Merged

chore(frontend): update cml test script to ignore flaky tests #537

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 14 additions & 17 deletions ci/scripts/test_cml.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,8 @@ CP_VERSION="current"
# Set to 1 only to debug quickly
DO_QUICK_SCRIPT_DEBUG=0

# Set to 1 to use exactly the pytest commandline of ML team. However, it's longer, since it runs
# the full test, while the one in this script exits at first problem
DO_USE_CML_PYTEST_COMMANDLINE=0
# Set to 1 to stop the CI at the first test that fails
STOP_AT_FIRST_FAIL=0

# Which python to use, to create the venv
PYTHON=python
Expand Down Expand Up @@ -75,8 +74,8 @@ do
DO_QUICK_SCRIPT_DEBUG=1
;;

"--use_cml_command_line" )
DO_USE_CML_PYTEST_COMMANDLINE=1
"--stop_at_first_fail" )
STOP_AT_FIRST_FAIL=1
;;

"--ml_branch" )
Expand Down Expand Up @@ -180,19 +179,17 @@ INSTALLED_CP=`pip freeze | grep "concrete-python"`
echo
echo "Installed Concrete-Python: ${INSTALLED_CP}"

# Launch CML pytests
# Launch CML tests with pytest (and ignore flaky ones)
# As compared to regular `make pytest`, known flaky errors from Concrete ML are simply ignored
# and coverage is disabled
# The "-x" option is added so that the run stops at the first test that fails
echo
echo "Launching CML tests"

if [ $DO_USE_CML_PYTEST_COMMANDLINE -eq 1 ]
echo "Launching CML tests (no flaky)"
if [ $STOP_AT_FIRST_FAIL -eq 1 ]
then
echo "make pytest"
make pytest
echo "make pytest_no_flaky PYTEST_OPTIONS="-x""
make pytest_no_flaky PYTEST_OPTIONS="-x"
else
# As compared to ML pytest:
# No coverage
# Stop at first error
echo "poetry run pytest -xsvv -n 4 --randomly-dont-reorganize --randomly-dont-reset-seed"
poetry run pytest -xsvv -n 4 --randomly-dont-reorganize --randomly-dont-reset-seed

echo "make pytest_no_flaky"
make pytest_no_flaky
fi