Fix download via popup on Edge #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Great job, no security vulnerabilities found in this Pull Request |
Fixes: zaproxy#208 Signed-off-by: Simon Bennetts <psiinon@gmail.com>
thc202
approved these changes
Jun 18, 2025
Member
|
Thank you! |
kingthorin
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #208
The fix is enabling the Download button all of the time, as Chrome and Edge dont get notifications that the popup dialog has been shown.
However the code has been changed to do nothing when that button is clicked if no statements have been recorded.
Also close notification dialog when script downloaded directly.