Pscanbeta - add polyfill.io scan rule #5536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psiinon
force-pushed
the
pscanbeta/polyfill
branch
2 times, most recently
from
5644ab0
to
d2c5e16
Compare
kingthorin
reviewed
Jun 27, 2024
...esBeta/src/main/java/org/zaproxy/zap/extension/pscanrulesBeta/PolyfillCdnScriptScanRule.java
Outdated
Show resolved
Hide resolved
...esBeta/src/main/java/org/zaproxy/zap/extension/pscanrulesBeta/PolyfillCdnScriptScanRule.java
Outdated
Show resolved
Hide resolved
...ta/src/main/resources/org/zaproxy/zap/extension/pscanrulesBeta/resources/Messages.properties
Outdated
Show resolved
Hide resolved
kingthorin
reviewed
Jun 27, 2024
...esBeta/src/main/java/org/zaproxy/zap/extension/pscanrulesBeta/PolyfillCdnScriptScanRule.java
Outdated
Show resolved
Hide resolved
psiinon
force-pushed
the
pscanbeta/polyfill
branch
from
d2c5e16
to
507944c
Compare
|
Thanks - hopefully all now fixed? |
kingthorin
reviewed
Jun 27, 2024
| private static final int PLUGIN_ID = 10115; | ||
|
|
||
| private static Pattern POLYFILL_IO = | ||
| Pattern.compile("http[s]?://.*polyfill\\.io/.*", Pattern.CASE_INSENSITIVE); |
There was a problem hiding this comment.
The square brackets could be dropped but not a blocker
kingthorin
approved these changes
Jun 27, 2024
psiinon
force-pushed
the
pscanbeta/polyfill
branch
from
507944c
to
2d28f6d
Compare
kingthorin
reviewed
Jun 27, 2024
...esBeta/src/main/java/org/zaproxy/zap/extension/pscanrulesBeta/PolyfillCdnScriptScanRule.java
Show resolved
Hide resolved
...esBeta/src/main/java/org/zaproxy/zap/extension/pscanrulesBeta/PolyfillCdnScriptScanRule.java
Outdated
Show resolved
Hide resolved
psiinon
force-pushed
the
pscanbeta/polyfill
branch
from
2d28f6d
to
5257e74
Compare
Signed-off-by: Simon Bennetts <psiinon@gmail.com>
psiinon
force-pushed
the
pscanbeta/polyfill
branch
from
5257e74
to
2a8e92c
Compare
thc202
approved these changes
Jun 27, 2024
|
Thank you! |
kingthorin
approved these changes
Jun 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Briefly describe the purpose, goals, and changes or improvements made in this pull request.
Related Issues
Specify any related issues or pull requests by linking to them.
Checklist
./gradlew spotlessApplyfor code formattingFor more details, please refer to the developer rules and guidelines.