reports: HTML add sequence support #5918
Conversation
kingthorin
force-pushed
the
rpt-html-seq
branch
2 times, most recently
from
5fd3c37
to
476c7ed
Compare
|
Probably needs further tests implemented. |
kingthorin
force-pushed
the
rpt-html-seq
branch
from
476c7ed
to
4ff4b4c
Compare
Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
kingthorin
force-pushed
the
rpt-html-seq
branch
from
4ff4b4c
to
0eab702
Compare
|
I'm quite confused about the needed white space changes and why the report files seem so inconsistent on spaces vs tabs. Especially when spotless seems to impact them as well. |
| th:if="${reportData.reportObjects.get('seqAScanData') != null}"> | ||
| <h3 th:text="#{report.sequences.summary.name}">Summary of | ||
| Sequences</h3> | ||
| <sup>For each step: result (Pass/Fail) - risk (of highest |
| @@ -518,6 +518,116 @@ <h3 th:text="#{report.alerts.detail}">Alert Detail</h3> | |||
| <div class="spacer"></div> | |||
| </th:block> | |||
| </th:block> | |||
|
|
|||
| <th:block th:if="${reportData.isIncludeSection('sequencedetails')}"> | |||
| <th:block | |||
There was a problem hiding this comment.
I would have the summary block much higher, maybe after "Summary of Alerts" ?
| <th:block th:each="step, stepState: ${seq.getSteps()}"> | ||
| <td th:class="(${step.isPass()} ? 'pass' : 'fail')" | ||
| th:with="riskLvl=(${step.getHighestAlert()})"><span | ||
| th:text="(${step.isPass()} ? 'Pass' : 'Fail')">isPass</span> <span |
There was a problem hiding this comment.
If we use text it should be i18n but tbh I'd prefer not to have any text. We could have tick / cross if the colour isnt sufficient.
How about also having a seq id which links to the relevant step below?
| <th:block | ||
| th:each="seq, seqState: ${reportData.reportObjects.get('seqAScanData').seqData}"> | ||
| <table class="alerts"> | ||
| <tr> |
There was a problem hiding this comment.
For long sequences we should spread this over multiple lines, eg if a sequence has 60 steps this wouldnt look good?
| <th:block th:each="step, stepState: ${seq.getSteps()}"> | ||
|
|
||
| <h4 | ||
| th:text="'Step ' + ${stepState.index + 1} + ': ' + ${step.getOriginalMsg().getRequestHeader().getMethod()} + ' - ' + ${step.getOriginalMsg().getRequestHeader().getURI().toString()}">stepDesc</h4> |
| </div> | ||
|
|
||
| <table> | ||
| <th colspan="2" th:text="#{report.sequences.step.original}">Original</th> |
There was a problem hiding this comment.
This is black on dark grey in light mode, so v difficult to read.
|
there were a few other texts that should be i18n'ed |
Overview
TBC
Related Issues
Checklist
./gradlew spotlessApplyfor code formatting