Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull build step into separate job #105

Closed
wants to merge 1 commit into from

Conversation

RothAndrew
Copy link
Contributor

@RothAndrew RothAndrew commented Oct 12, 2021

What/Why

  • Pull the building of the binaries out into a separate job so it doesn't get run more than once when we add more E2E tests

Working PoC here: https://github.com/defenseunicorns/slash-command-dispatch-test/pull/5

The time for the pipeline to run is getting a bit long (~15m) and it still doesn't really even do much yet. It's mostly due to uploading and downloading of big files, both in the pipeline between jobs and sending them up to the EC2 instance(s). It's definitely worth looking into further.

@RothAndrew RothAndrew self-assigned this Oct 12, 2021
@RothAndrew
Copy link
Contributor Author

/test all

@RothAndrew
Copy link
Contributor Author

Closing in favor of #106

@RothAndrew RothAndrew closed this Oct 15, 2021
@jeff-mccoy jeff-mccoy deleted the feature/better-e2e-testing branch March 12, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant