Prep the GitHub Actions setup for handling more than one E2E test #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test e2e |
1 similar comment
|
/test e2e |
RothAndrew
changed the title
|
/test all |
RothAndrew
requested review from
jeff-mccoy,
btlghrants,
matt-strong and
YrrepNoj
|
/test all |
|
Ready for review. @YrrepNoj let's get together Monday and pair on creating a 2nd E2E test that builds on this. If this isn't merged quite yet we can branch off of this and work on it as a draft until after this gets merged. |
RothAndrew
force-pushed
the
feature/add-another-e2e-test
branch
from
f56de06
to
b32af17
Compare
|
/test all |
jeff-mccoy
reviewed
Oct 15, 2021
Merged
YrrepNoj
approved these changes
Oct 19, 2021
jeff-mccoy
pushed a commit
that referenced
this pull request
Feb 8, 2022
Signed-off-by: Jeff McCoy <code@jeffm.us>
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
Signed-off-by: Jeff McCoy <code@jeffm.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why
/test buildor on any other test target that needs it as a dependency.e2etoe2e-gamesince it now runs the game example. This sets up the ability to add more tests that all run in parallel and all report their own status check back to the PR so that the developer experience is really nice and easy to work with. This will require changing up the required status checks in the branch protections a bit, but shouldn't mean any extra work on the dev's part. They'll still just run/test e2eor/test all.package-examplestarget. It's already inexamples/Makefileand will be confusing since it creates stuff in the examples folder while everything else in that makefile makes stuff in the build folder.package-example-gameandtest-cloud-e2e-example-gametargets. This is starting to set up the pattern for how other E2E tests will look. My vision right now is that each E2E test has a target for building the deploy package, a target for running the cloud-based E2E that the pipeline uses, and a target that can be used locally in vagrant, which will get dogfooded by the cloud-based test. It doesn't exist yet but I want to make atest-local-e2e-example-gametarget as part of Each E2E test should be runnable locally #100.common.goe2d_example_game_test.go, make it run the game example, and assert whether it is available not athttps://localhostWorking PoC here: https://github.com/defenseunicorns/slash-command-dispatch-test/pull/6