Skip to content

Commit

Permalink
Merge pull request #89 from jakirkham/drop_py34
Browse files Browse the repository at this point in the history
Drop Python 3.4
  • Loading branch information
jakirkham authored Nov 2, 2018
2 parents e7cc69d + 75d6f55 commit baa834f
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 14 deletions.
1 change: 0 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ addons:

python:
- 2.7
- 3.4
- 3.5
- 3.6

Expand Down
7 changes: 0 additions & 7 deletions appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,6 @@ environment:
PYTHON_VERSION: "2.7"
DISTUTILS_USE_SDK: "1"

- PYTHON: "C:\\Python34"
PYTHON_VERSION: "3.4"

- PYTHON: "C:\\Python34-x64"
PYTHON_VERSION: "3.4"
DISTUTILS_USE_SDK: "1"

- PYTHON: "C:\\Python35"
PYTHON_VERSION: "3.5"

Expand Down
4 changes: 2 additions & 2 deletions docs/contributing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,9 @@ To also run the doctests within docstrings, run::
Tests can be run under different Python versions using tox. E.g. (assuming you have the
corresponding Python interpreters installed on your system)::

$ tox -e py27,py34,py35,py36
$ tox -e py27,py35,py36

NumCodecs currently supports Python 2.7 and Python 3.4-3.6, so the above command must
NumCodecs currently supports Python 2.7 and Python 3.5-3.6, so the above command must
succeed before code can be accepted into the main code base. Note that only the py36
tox environment runs the doctests, i.e., doctests only need to succeed under Python 3.6.

Expand Down
2 changes: 2 additions & 0 deletions docs/release.rst
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ Release notes
* Updated the msgpack dependency (by :user:`Jerome Kelleher <jeromekelleher>`;
:issue:`74`, :issue:`75`).

* Drop Python 3.4 (by :user:`John Kirkham <jakirkham>`; :issue:`89`).

.. _release_0.5.5:

0.5.5
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -339,8 +339,8 @@ def run_setup(with_extensions):
'Programming Language :: Python :: 2',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.4',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
],
author='Alistair Miles',
author_email='alimanfoo@googlemail.com',
Expand Down
6 changes: 3 additions & 3 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,17 @@
# and then run "tox" from this directory.

[tox]
envlist = py27, py34, py35, py36, docs
envlist = py27, py35, py36, docs

[testenv]
setenv =
PYTHONHASHSEED = 42
# hooks for coverage exclusions based on Python major version
py34,py35,py36: PY_MAJOR_VERSION = py3
py35,py36: PY_MAJOR_VERSION = py3
py27: PY_MAJOR_VERSION = py2
commands =
python setup.py build_ext --inplace
py27,py34,py35: pytest -v --cov=numcodecs numcodecs
py27,py35: pytest -v --cov=numcodecs numcodecs
py36: pytest -v --cov=numcodecs --doctest-modules --doctest-glob=*.pyx numcodecs
coverage report -m
py36: flake8 --max-line-length=100 numcodecs
Expand Down

0 comments on commit baa834f

Please sign in to comment.