Drop Python 3.4 #89
Merged
Drop Python 3.4 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we have already dropped Python 3.4 support in Zarr and we are about to add Python 3.7 support here, go ahead and drop Python 3.4 support in Numcodecs as well.
Adds Python 3.6 to the trove classifiers. It was already supported, but got missed in this list. So go ahead and add it.
Add this to the changelog since it is user facing. Though probably does not effect that many users at this point.
alimanfoo
approved these changes
Oct 31, 2018
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing that we go ahead and drop Python 3.4 from Numcodecs. It's already been dropped from Zarr. ( zarr-developers/zarr-python#308 ) Also it seems some associated projects (e.g. Dask, XArray, etc.) already have dropped Python 3.4. Finally since we plan to add Python 3.7 here soon, it makes sense to go ahead and drop the older of the Python 3s. Feedback welcome.
TODO:
tox -e py36passes locallytox -e py27passes locallytox -e docspasses locally