-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 3.6 #318
Drop Python 3.6 #318
Conversation
@jakirkham, thoughts or help on the feedstock front(s) welcome. |
@@ -346,7 +346,7 @@ def run_setup(with_extensions): | |||
ext_modules=ext_modules, | |||
cmdclass=cmdclass, | |||
package_dir={"": "."}, | |||
python_requires=">=3.6, <4", | |||
python_requires=">=3.7, <4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is likely debatable since we're not explicitly breaking compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eh I think it is ok to drop. We are not testing it any more. So we really can't guarantee things work there.
Might be worth updating # Skip building on CPython 3.6 on all platforms
CIBW_SKIP: cp36-* |
Changed 3.6 branch protection for |
The hanging |
May need to push another commit |
Think the failure was just a temporary pypi access problem. Green now. |
Good try, but I think it takes a new PR 😉 |
Yeah it may. Sorry pushed a couple more things. There was an old notebook that I reran. It has an issue we might need to follow up on ( #319 ). Also added a release note. Otherwise LGTM Thanks for working on this Josh! 😄 🙏 |
Hmm..was hoping that would trigger RTD without having to restart all the builds. Doesn't seem to have, but won't push on that any further in this PR. |
So the wheel job has actually completed, but the status is still showing pending. Going to merge anyways. |
Still seeing the Python 3.6 status as pending in PR ( #320 ). Guessing we are missing something |
Think I figured it out. Python 3.6 was still listed in the branch protection rules for |
see: #317
see: zarr-developers/zarr-python#765
tox -e py39
passes locallytox -e docs
passes locally