Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.6 #318

Merged
merged 5 commits into from
May 6, 2022
Merged

Drop Python 3.6 #318

merged 5 commits into from
May 6, 2022

Conversation

joshmoore
Copy link
Member

see: #317
see: zarr-developers/zarr-python#765

  • Unit tests and/or doctests in docstrings
  • tox -e py39 passes locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • tox -e docs passes locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Coveralls passes)

@joshmoore
Copy link
Member Author

@jakirkham, thoughts or help on the feedstock front(s) welcome.

@@ -346,7 +346,7 @@ def run_setup(with_extensions):
ext_modules=ext_modules,
cmdclass=cmdclass,
package_dir={"": "."},
python_requires=">=3.6, <4",
python_requires=">=3.7, <4",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is likely debatable since we're not explicitly breaking compatibility.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh I think it is ok to drop. We are not testing it any more. So we really can't guarantee things work there.

@jakirkham
Copy link
Member

Might be worth updating cibuildwheel. Also think we can skip certain builds. From their docs, this looks useful:

# Skip building on CPython 3.6 on all platforms
CIBW_SKIP: cp36-*

@joshmoore
Copy link
Member Author

Changed 3.6 branch protection for master to 3.10. Closing and re-opening.

@joshmoore joshmoore closed this May 6, 2022
@joshmoore joshmoore reopened this May 6, 2022
@joshmoore
Copy link
Member Author

The hanging build (3.6) Expected — Waiting for status to be reported build apparently isn't going away, but the build will pass without.

@jakirkham
Copy link
Member

May need to push another commit

@joshmoore
Copy link
Member Author

Think the failure was just a temporary pypi access problem. Green now.

@joshmoore
Copy link
Member Author

Good try, but I think it takes a new PR 😉

@jakirkham
Copy link
Member

Yeah it may. Sorry pushed a couple more things. There was an old notebook that I reran. It has an issue we might need to follow up on ( #319 ). Also added a release note. Otherwise LGTM

Thanks for working on this Josh! 😄 🙏

@jakirkham jakirkham marked this pull request as draft May 6, 2022 18:13
@jakirkham jakirkham marked this pull request as ready for review May 6, 2022 18:13
@jakirkham
Copy link
Member

Hmm..was hoping that would trigger RTD without having to restart all the builds. Doesn't seem to have, but won't push on that any further in this PR.

@jakirkham
Copy link
Member

So the wheel job has actually completed, but the status is still showing pending. Going to merge anyways.

@jakirkham jakirkham merged commit 581848e into zarr-developers:master May 6, 2022
This was referenced May 6, 2022
@jakirkham
Copy link
Member

Still seeing the Python 3.6 status as pending in PR ( #320 ). Guessing we are missing something

@jakirkham
Copy link
Member

Think I figured it out. Python 3.6 was still listed in the branch protection rules for master on GitHub. Removing it from that list seems to have fixed the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants