Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate Py 3.10 builds #1027

Merged
merged 7 commits into from
May 11, 2022
Merged

Activate Py 3.10 builds #1027

merged 7 commits into from
May 11, 2022

Conversation

joshmoore
Copy link
Member

With the freeze for Python 3.11 (https://www.python.org/downloads/release/python-3110b1/), I thought it would make sense to at least try out the latest in a PR. We likely will want to re-evaluate the matrix and perhaps set some items to optional.

@jakirkham
Copy link
Member

Guessing there are missing dependencies

@joshmoore
Copy link
Member Author

joshmoore commented May 11, 2022

🤦🏽 Was reading setup-python documentation but we use setup-conda. I'll keep digging. Worst case, I'll create a simple workflow that uses setup-python.

Edit: yeah, https://anaconda.org/conda-forge/python/labels doesn't seem to have any builds yet.

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (972c912) to head (b626ef7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1027   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          34       34           
  Lines       13785    13788    +3     
=======================================
+ Hits        13778    13781    +3     
  Misses          7        7           

see 2 files with indirect coverage changes

@joshmoore
Copy link
Member Author

Pushed directly to origin to test (see https://github.com/zarr-developers/zarr-python/runs/6385329519?check_suite_focus=true) but of course now we're getting into building wheels for numpy, numcodecs, etc.

Likely just too premature, sadly.

@joshmoore joshmoore closed this May 11, 2022
@jakirkham
Copy link
Member

Yeah unfortunately. There are people starting to look into it

That said, adding Python 3.10 makes a lot of sense

@joshmoore joshmoore changed the title Activate Py 3.10 and 3.11 beta Activate Py 3.10 builds May 11, 2022
@joshmoore joshmoore reopened this May 11, 2022
@joshmoore
Copy link
Member Author

Fair enough. Dropped the 3.11b1 build and re-opened.

@joshmoore joshmoore merged commit b9b9bf9 into zarr-developers:master May 11, 2022
@joshmoore joshmoore deleted the 3.11b1 branch May 11, 2022 19:48
@jakirkham
Copy link
Member

Thanks Josh! 🙏

@jakirkham
Copy link
Member

Also just as a note, we added Python 3.10 to Numcodecs in PR ( zarr-developers/numcodecs#318 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants