-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds crc32c codec #613
Adds crc32c codec #613
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #613 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 59 59
Lines 2326 2405 +79
=======================================
+ Hits 2324 2403 +79
Misses 2 2
|
Should this live in https://github.com/zarr-developers/numcodecs/blob/main/numcodecs/checksum32.py, where we already have |
I didn't look for |
I moved the code to checksum32.py and refactored the tests (they had no parameterization) in 7e78d93 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - just a few questions, but none of them blocking.
I don't see why this PR isn't ready to merge (it might be just late)? Do I need another approval? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just needs a fresh approval?
Adds Crc32c codec, which appends a crc32c checksum to the input buffer when encoding and validates the checksum when decoding.
Fixes #610
TODO: