Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slim dependencies #2395

Closed
wants to merge 5 commits into from
Closed

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Oct 17, 2024

This PR implements the main ideas from #2391, removing crc32c and fsspec as core dependencies and adding them to the sharding and remote groups respectively. Imports are adjusted in minor ways and we now take advantage of pytest.importorskip in a few new places.

TODO: if we decide to go this route, we should have a separate part of the test matrix that includes optional dependencies.

Closes #2391
Fixes #735

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

Copy link
Contributor

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're coming to a consensus in #2391 (?) of

For the second one, would be good to add some docs explaining how to install the remote extra, and what functionality it enables.

pyproject.toml Outdated Show resolved Hide resolved
@jhamman
Copy link
Member Author

jhamman commented Oct 21, 2024

Something I learned over the weekend is that crc32c is LGPL Licensed. Regardless of whether we get crc32c into numcodecs, we may want to pick a different implementation (googleapis/python-crc32c is Apache 2.0 licenced).

pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rethinking Zarr's core dependencies Update fsspec minimal version?
2 participants