-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slim dependencies #2395
Slim dependencies #2395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're coming to a consensus in #2391 (?) of
- Move dependency of
crc32c
to numcodecs (Add crc32c codec numcodecs#610) - Make
fsspec
optional
For the second one, would be good to add some docs explaining how to install the remote
extra, and what functionality it enables.
Something I learned over the weekend is that |
This PR implements the main ideas from #2391, removing
crc32c
andfsspec
as core dependencies and adding them to thesharding
andremote
groups respectively. Imports are adjusted in minor ways and we now take advantage ofpytest.importorskip
in a few new places.TODO: if we decide to go this route, we should have a separate part of the test matrix that includes optional dependencies.
Closes #2391
Fixes #735
TODO: