Require fill_value to be defined
#145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. |
d-v-b
reviewed
Jun 1, 2022
|
Per discussion at the last meeting, I believe there was consensus that this should be merged. I think the explicit ban on |
jstriebel
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
LGTM 👍
To move forward with the spec I'm merging this. I think everyone agreed to make the fill_value required, but feel free to open an issue or PR if that's not the case, or the note about null values should be changed. Merging this doesn't mean it's set in stone, but hopefully enables more progress and refinements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133