Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require fill_value to be defined #145

Merged
merged 2 commits into from
Nov 7, 2022
Merged

Require fill_value to be defined #145

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f95540
Require `fill_value` to be defined
jakirkham Jun 1, 2022
8786b70
Note there may be internal default fill values
jakirkham Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions docs/core/v3.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1031,10 +1031,11 @@ following mandatory names:
value must be a number with no fraction or exponent part and must
be within the range of the data type.

For any data type, if the ``fill_value`` is the literal ``null``
then the fill value is undefined and the implementation may use
any arbitrary value that is consistent with the data type as the
fill value.
For any data type, the ``fill_value`` is required. The literal
``null`` is not permitted. The fill value needs to be defined
jstriebel marked this conversation as resolved.
Show resolved Hide resolved
so that the data is independent of implementation details. Internally
implementations may provide a default ``fill_value``, but that must
be converted to a fixed value in the stored metadata.

If the ``data_type`` of an array is defined in a ``data_type`` extension,
then said extension is responsible for interpreting the value of
Expand Down