Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow resize and add autosize to the filter box (close #177) #193

Merged
merged 3 commits into from
Nov 15, 2021

Conversation

natenho
Copy link
Contributor

@natenho natenho commented Feb 25, 2021

@zarunbal please review the code. You'll notice some misplaced code in form designer code, unfortunately VS2019 seems to be not too friendly with multiple partial form files. IMHO all these logic should be moved to specialized classes instead of partial form files.

  • Dragging the splitter allow free filter box resizing
  • You can see that a double click will auto resize the filter box expanding to the maximum text width
  • The filter box font was changed so it can be easier to read and relate to the log itself

logexpert

@natenho natenho changed the base branch from master to Development February 25, 2021 02:07
@Hirogen Hirogen added enhancement this will make things better Feature what a great idea labels Nov 11, 2021
@Hirogen Hirogen added this to the Release 1.8.8 milestone Nov 11, 2021
Copy link
Collaborator

@Hirogen Hirogen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In filterSplitContainer_MouseMove please cast the object only once
ex: SplitContainer container = (SplitContainer)sender;

this will make the source code clearer to read and also it is only converted once, not multiple times

other than that looks fine for me

@Hirogen Hirogen merged commit 839029a into zarunbal:Development Nov 15, 2021
@natenho natenho deleted the feature/#177-resize-filter-box branch March 20, 2022 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement this will make things better Feature what a great idea
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants