Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Versions, Framework and NuGet Packages #293

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

KaiL3
Copy link

@KaiL3 KaiL3 commented Feb 28, 2024

Update Framework to 4.8.1
Update .netcore 3.1 => .net 8
Update all NuGet Packages
Depend on Update the TestPackage, migrate the Testcode AreEqual => That()

KaiL3 added 2 commits February 28, 2024 10:20
Update .netcore 3.1 => .net 8
Update all NuGet Packages
Depend on Update the TestPackage, migrate the Testcode AreEqual => That()
@KaiL3
Copy link
Author

KaiL3 commented Feb 28, 2024

Sorry for this confusion, but i would like opening a new Pullrequest from the Development Branch to the Development Branch. In this request are included the .net 8 update from the build project.

@Hirogen Hirogen merged commit 93e0a23 into zarunbal:Development Feb 28, 2024
1 check passed
@KaiL3
Copy link
Author

KaiL3 commented Feb 28, 2024

Hi Patrick, I'm surprised. When testing this pull request, it was compiled against .NET 4.7.2. Actually I would have expected .NET 4.8.1 and after the merge the developer pack for the new .NET version was missing.
Have you also noticed this?

@Hirogen
Copy link
Collaborator

Hirogen commented Feb 29, 2024

not really, since target framework is 4.8.1, very strange

@KaiL3
Copy link
Author

KaiL3 commented Mar 1, 2024

The Developer Pack .NET 4.8.1 must be installed in the pipeline for compilation. Alternatively, a downgrade to .NET Framework 4.8 should also work.
It is interesting that the initial tests did not run on 4.8.1, but on 4.7.2. I tested the build locally, where everything worked. Except for the setup and the package manager, which I did not install locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants