wallet migration broken when accounts table includes a UFVK that lacks a Transparent key

[AArnott]

After upgrading eZcash to consume zcash_client_sqlite-0.11.1, I found that wallet migrations lead to an error, crashing the app.

This is blocking an eZcash release that adds support for TEX addresses

Specifically, when the accounts table includes an account defined by only a UFVK without a Transparent key, the ephemeral_addresses.rs migration fails:

librustzcash/zcash_client_sqlite/src/wallet/transparent/ephemeral.rs

Lines 133 to 137 in cdf993d

	let eivk = ufvk
	.as_ref()
	.and_then(|ufvk| ufvk.transparent())
	.ok_or(SqliteClientError::UnknownZip32Derivation)?
	.derive_ephemeral_ivk()?;

The ok_or function returns an error, that ultimately is rendered as this message:

internal error: entered unreachable code: we don't call methods that require operating on imported accounts

The callstack at this point is:

>	nerdbank_zcash_rust.dll!zcash_client_sqlite::wallet::transparent::ephemeral::get_ephemeral_ivk<zcash_protocol::consensus::Network>(rusqlite::Connection * conn, zcash_protocol::consensus::Network * params, zcash_client_sqlite::AccountId account_id) Line 133	Rust
 	nerdbank_zcash_rust.dll!zcash_client_sqlite::wallet::transparent::ephemeral::reserve_until<zcash_protocol::consensus::Network>(rusqlite::transaction::Transaction * conn, zcash_protocol::consensus::Network * params, zcash_client_sqlite::AccountId account_id, unsigned int next_to_reserve) Line 291	Rust
 	nerdbank_zcash_rust.dll!zcash_client_sqlite::wallet::transparent::ephemeral::init_account<zcash_protocol::consensus::Network>(rusqlite::transaction::Transaction * conn, zcash_protocol::consensus::Network * params, zcash_client_sqlite::AccountId account_id) Line 265	Rust
 	nerdbank_zcash_rust.dll!zcash_client_sqlite::wallet::init::migrations::ephemeral_addresses::impl$1::up<zcash_protocol::consensus::Network>(zcash_client_sqlite::wallet::init::migrations::ephemeral_addresses::Migration<zcash_protocol::consensus::Network> * self, rusqlite::transaction::Transaction * transaction) Line 71	Rust
 	nerdbank_zcash_rust.dll!schemer_rusqlite::impl$2::apply_migration<enum2$<zcash_client_sqlite::wallet::init::WalletMigrationError>>(schemer_rusqlite::RusqliteAdapter<enum2$<zcash_client_sqlite::wallet::init::WalletMigrationError>> * self, ref$<dyn$<schemer_rusqlite::RusqliteMigration<assoc$<Error,enum2$<zcash_client_sqlite::wallet::init::WalletMigrationError>>>>>) Line 164	Rust
 	nerdbank_zcash_rust.dll!schemer::Migrator<schemer_rusqlite::RusqliteAdapter<enum2$<zcash_client_sqlite::wallet::init::WalletMigrationError>>>::up<schemer_rusqlite::RusqliteAdapter<enum2$<zcash_client_sqlite::wallet::init::WalletMigrationError>>>(enum2$<core::option::Option<uuid::Uuid>> self) Line 305	Rust
 	nerdbank_zcash_rust.dll!zcash_client_sqlite::wallet::init::init_wallet_db_internal<zcash_protocol::consensus::Network>(zcash_client_sqlite::WalletDb<rusqlite::Connection,zcash_protocol::consensus::Network> * wdb, enum2$<core::option::Option<secrecy::Secret<alloc::vec::Vec<u8,alloc::alloc::Global>>>> seed, ref$<slice2$<uuid::Uuid>> verify_seed_relevance, bool) Line 327	Rust
 	nerdbank_zcash_rust.dll!zcash_client_sqlite::wallet::init::init_wallet_db<zcash_protocol::consensus::Network>(zcash_client_sqlite::WalletDb<rusqlite::Connection,zcash_protocol::consensus::Network> * wdb, enum2$<core::option::Option<secrecy::Secret<alloc::vec::Vec<u8,alloc::alloc::Global>>>> seed) Line 300	Rust

[nuttycom]

This is fixed by #1524

[AArnott]

Are there any changes in this commit or any other changes since the last release that would make it inadvisable for me to merge your branch in directly rather than waiting for another official release?

[nuttycom]

I don't expect any other changes to be needed here.

…

On Sat, Sep 7, 2024 at 8:06 AM Andrew Arnott ***@***.***> wrote: Are there any changes in this commit or any other changes since the last release that would make it inadvisable for me to merge your branch in directly rather than waiting for another official release? — Reply to this email directly, view it on GitHub <#1531 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAGXR2YSRK562T2CLR6VRLZVMB5HAVCNFSM6AAAAABN2BMAPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZVGE4TONZUHA> . You are receiving this because you commented.Message ID: ***@***.***>

[nuttycom]

#1524 is merged