zcash_client_sqlite: Do not require a transparent key for migrations. #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `reserve_until` method for generating ephemeral addresses is used in database migrations, but it makes no sense to use this in the case that the UFVK for an account contains no transparent component; such accounts can never be used to make ZIP 320 spends.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1524 +/- ##
==========================================
- Coverage 61.06% 61.06% -0.01%
==========================================
Files 141 141
Lines 16675 16675
==========================================
- Hits 10183 10182 -1
- Misses 6492 6493 +1 ☔ View full report in Codecov by Sentry. |
AArnott
added a commit
to nerdcash/librustzcash
that referenced
this pull request
Sep 7, 2024
This reverts commit 0956b66. This is because the official fix in zcash#1524 will address the bug another way.
daira
reviewed
Sep 8, 2024
| ])?; | ||
| // used_in_tx and seen_in_tx are initially NULL | ||
| let mut stmt_insert_ephemeral_address = conn.prepare_cached( | ||
| "INSERT INTO ephemeral_addresses (account_id, address_index, address) |
There was a problem hiding this comment.
Non-blocking typo below: "indicies"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
reserve_untilmethod for generating ephemeral addresses is used in database migrations, but it makes no sense to use this in the case that the UFVK for an account contains no transparent component; such accounts can never be used to make ZIP 320 spends.