Some cleanup/doc on the item icons #1263
Conversation
| gQuestIconZoraSapphireTex, // ITEM_SPSTONE_ZORA_SAPPHIRE | ||
| gQuestIconStoneOfAgonyTex, // ITEM_STONE_OF_AGONY | ||
| gQuestIconGerudosCardTex, // ITEM_GERUDOS_CARD | ||
| gQuestIconGoldSkulltulaTex, // ITEM_SKULL_TOKEN |
There was a problem hiding this comment.
One of these should definitely change.
There was a problem hiding this comment.
Well I have a dilemma here, because ITEM_SKULL_TOKEN is the token item, but gQuestIconGoldSkulltulaTex is a gold skulltula icon that looks nothing like the token
There was a problem hiding this comment.
I think it can still be an icon for it even if it doesn't look the same. The heart piece indicator doesn't look anything like the ones you pick up, for example.
There was a problem hiding this comment.
Note I didn't touch the gHeartPieceIcon*Tex names, they indeed probably shouldn't be called "icon" (any suggestion? as well as for the gItemIcons array),
but the (unused) gQuestIconHeartPieceTex does look like the in-game heart piece
There was a problem hiding this comment.
I suppose the heart piece one is a gauge/meter, albeit an unconventional layout.
At the end of the day it does still look like a gold skulltula.
(gQuestIconSpidersSquishedTex)
src/code/code_80097A00.c
Outdated
| gQuestIconDungeonBossKeyTex, // ITEM_DUNGEON_BOSS_KEY | ||
| gQuestIconDungeonMapTex, // ITEM_DUNGEON_COMPASS (swapped with map?) | ||
| gQuestIconDungeonCompassTex, // ITEM_DUNGEON_MAP | ||
| gQuestIconDungeonBossKeyTex, // ITEM_SMALL_KEY |
There was a problem hiding this comment.
Huh, it uses boss key for both, or...?
There was a problem hiding this comment.
I can't tell if any of these 4 actually uses this array to get the icon, it doesn't seem like it but idk. At least ITEM_SMALL_KEY I think is never used in pause?
There was a problem hiding this comment.
Added comments on the three odd item->texture mappings (map, compass, small key)
It's inconsequential for all three (as gItemIcons isn't accessed for those items)
|
I'm stuck on understanding what each biggoron sword/giant knife -related item is
See the |
|
I would also update the |
fig02
added
the
Needs discussion
Dragorn421
changed the title
Dragorn421
removed
the
Needs discussion
|
With #1376 having been merged this PR is back in business 🎉 |
| @@ -99,7 +99,7 @@ | |||
| #define R_TEXTBOX_HEIGHT YREG(23) | |||
| #define R_TEXTBOX_ICON_XPOS YREG(71) | |||
| #define R_TEXTBOX_ICON_YPOS YREG(72) | |||
| #define R_TEXTBOX_ICON_SIZE YREG(75) | |||
| #define R_TEXTBOX_ICON_DIMENSION YREG(75) | |||
There was a problem hiding this comment.
I'd probably prefer Length over Dimension, but it seems fine as is.
There was a problem hiding this comment.
possibly, though to me length makes it sound like its only for that one side. while this is trying to convey that its the same number for length and width. but yeah i guess its not that clear either way
There was a problem hiding this comment.
I'm keeping "dimension" until someone else says they prefer "length"
Dragorn421
added
Needs contributor approval
and removed
Needs contributor approval
labels
* Some cleanup/doc on the item enum and icons * `gItemIconBigBottlePoeTex` -> `gItemIconBottleBigPoeTex` * Biggoron sword / giant knife items (?) * `SPSTONE_` -> `SPIRITUAL_` ? * `gItemIconBrokenBiggoronSwordTex` -> `gItemIconBrokenGoronsSwordTex` * `gQuestIcon...MedallionTex` -> `gQuestIconMedallion...Tex` * `ITEM_MAGIC_` -> `ITEM_MAGIC_JAR_`small/big * `ITEM_BOW_ARROW_` -> `ITEM_BOW_` * `MASK_BUNNY` -> `MASK_BUNNY_HOOD` * Update `GID_` enum from `ITEM_` enum * ITEM/GID`_ARROW_`small/medium/large -> 5/10/30 * Run formatter * . * fix regressions and revert bad ideas * chicken * obey the newline police and also prevent the range police from intervening * fixups * dimensions -> dimension (singular) * Note on inconsequential oddities about the `gItemIcons` mapping
Main things:
gItemIconsincode_80097A00.c: format and some commentsz64interface.hto replace magic numbers refering toicon_item_static/icon_item_24_staticassets ("item icons" and "quest icons")