Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation pass on the pause menu (kaleido_scope) #1366

Draft
wants to merge 151 commits into
base: main
Choose a base branch
from

Conversation

Dragorn421
Copy link
Collaborator

@Dragorn421 Dragorn421 commented Aug 26, 2022

There's a lot to look at and it may take some time, so I figured I should open a PR as an indication that there's documentation being done on this

Very WIP and also probably going to end up very large
Did end up very large, nearing 100% (2022-11-16)


Related (and possibly conflicting) work to be aware of:

Elliptic's wip progression flags
master...EllipticEllipsis:oot:progession_flags
has a PAUSE_MAP_LOC_ enum for indexing PauseContext.worldMapPoints and PAUSE_MAP_POINT_VIS_ for the values
PAUSE_MAP_LOC_ is also used for PauseContext.tradeQuestLocation

My item enum/icons doc/cleanup PR
#1263
touches some of kaleido's assets usage

Copy link
Contributor

@engineer124 engineer124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some quick initial comments

include/z64.h Outdated Show resolved Hide resolved
src/code/z_parameter.c Outdated Show resolved Hide resolved
src/overlays/misc/ovl_kaleido_scope/z_kaleido_scope_PAL.c Outdated Show resolved Hide resolved
src/code/z_player_lib.c Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants