-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation pass on the pause menu (kaleido_scope) #1366
Draft
Dragorn421
wants to merge
151
commits into
zeldaret:main
Choose a base branch
from
Dragorn421:doc_pause_menu
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+735
−418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engineer124
reviewed
Aug 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some quick initial comments
…ure out the state 6 substates (unk_1E4)
mzxrules
reviewed
Sep 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a lot to look at and it may take some time, so I figured I should open a PR as an indication that there's documentation being done on this
Very WIP and also probably going to end up very largeDid end up very large, nearing 100% (2022-11-16)
Related (and possibly conflicting) work to be aware of:
Elliptic's wip progression flags
master...EllipticEllipsis:oot:progession_flags
has a
PAUSE_MAP_LOC_
enum for indexingPauseContext.worldMapPoints
andPAUSE_MAP_POINT_VIS_
for the valuesPAUSE_MAP_LOC_
is also used forPauseContext.tradeQuestLocation
My item enum/icons doc/cleanup PR
#1263
touches some of kaleido's assets usage