Document enum PauseState game over parts
#2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also, as previously, i've rerun the "make" to check integrity
in case it helps to rename them later, if the need ever arises
also i've noticed, that `z64pause.h` doesn't comply fully with the `.clang-format` temporary changing a couple of setting to - ColumnLimit: 0 - AlignTrailingComments: false fixes the issue. i don't want to push unrelated formatting here
Dragorn421
reviewed
Nov 4, 2024
fig02
reviewed
Nov 4, 2024
reverified with > `check_format.py ...` > `make ...`
fig02
approved these changes
Nov 4, 2024
Dragorn421
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renamed a set of pause states related to game over sequence
P.S.:
hi, new here 🌞
thank you for the titanic work you've accomplished so far! i've been rummaging around and studying the repo and thought to try and join
also i see there's a quite old kaleido_scope PR, which explicitly didn't touch game over pause states, thus this one should not conflict; much at least