Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packZpk is adding deployment scripts into scripts/scripts directory #5

Closed
swilczynski opened this issue Sep 17, 2013 · 3 comments
Closed
Labels

Comments

@swilczynski
Copy link
Contributor

It is creating scripts directory inside another scripts directory which makes Zend Server unable to unpack and execute deployment scripts like post_stage.php

This issue is probably caused by pack method of ZpkInvokable where it calls

$zpk->addFile($fullPath, $this->fixZipPath($baseDir.$path));

For scripts directory it tries to do

$zpk->addFile($fullPath, $this->fixZipPath('scripts/'.'scripts/post_stage.php'));

@slaff
Copy link
Contributor

slaff commented Sep 18, 2013

Confirmed bug.

slaff pushed a commit that referenced this issue Sep 18, 2013
Added special case for the scripts directory that matches more closely the ZendStudio logic.
@slaff
Copy link
Contributor

slaff commented Sep 18, 2013

The customer confirmed that the fix works for him.

@ryanheath86
Copy link

I created a pull request for this issue and it now works for me..

I didn't see a fix in the latest release or dev version, so I'm not sure if this was fixed yet

#56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants