chore: linting fixes and improvements

.github/workflows/checks.yml

@@ -3,7 +3,7 @@ name: Checks
 on:
   pull_request:
     branches:
-      - master
+      - "*"
   push:
     branches:
       - master
@@ -28,7 +28,7 @@ jobs:
       - name: Lint all commit messages
         run: yarn commitlint --from ${{ github.event.pull_request.base.sha }} --to ${{ github.event.pull_request.head.sha }}
   lint:
-    name: Lint JS files
+    name: Lint files and folders
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
@@ -41,6 +41,8 @@ jobs:
           node-version-file: '.nvmrc'
       - name: Install dependencies
         run: yarn install --frozen-lockfile
+      - name: LS-lint
+        run: yarn ls-lint
       - name: ESlint
         run: yarn eslint
   test:

.ls-lint.yml

@@ -0,0 +1,13 @@
+ls:
+  templates:
+    .hbs: snake_case
+  translations:
+    .json: kebab-case
+  src:
+    .dir: kebab-case
+    .js: camelCase | PascalCase
+    .spec.js: camelCase | PascalCase
+    .ts: camelCase | PascalCase
+
+ignore:
+  - node_modules

package.json

@@ -6,6 +6,7 @@
     "start": "concurrently -k -r 'rollup -c -w' 'wait-on script.js style.css && zcli themes:preview'",
     "build": "rollup -c",
     "eslint": "eslint src",
+    "ls-lint": "ls-lint",
     "prepare": "husky install",
     "download-locales": "node ./bin/update-translations",
     "test": "jest",
@@ -32,6 +33,8 @@
   "devDependencies": {
     "@commitlint/cli": "17.3.0",
     "@commitlint/config-conventional": "17.3.0",
+    "@jest/globals": "^29.6.4",
+    "@ls-lint/ls-lint": "^2.0.1",
     "@rollup/plugin-commonjs": "^25.0.2",
     "@rollup/plugin-node-resolve": "^15.1.0",
     "@rollup/plugin-replace": "^5.0.2",

src/Dropdown.spec.js

@@ -1,3 +1,4 @@
+import { expect, jest, describe, it, beforeEach } from "@jest/globals";
 import crypto from "crypto";
 import { fireEvent, screen } from "@testing-library/dom";
 import userEvent from "@testing-library/user-event";

src/modules/new-request-form/NewRequestForm.tsx

@@ -31,7 +31,7 @@ const Footer = styled.div`
 `;
 
 const DatePicker = lazy(() => import("./fields/DatePicker"));
-const CcField = lazy(() => import("./fields/CcField/CcField"));
+const CcField = lazy(() => import("./fields/cc-field/CcField"));
 
 export function NewRequestForm({
   ticketForms,
@@ -115,7 +115,7 @@ export function NewRequestForm({
               </Suspense>
             );
           case "multiselect":
-            return <MultiSelect field={field}/>;
+            return <MultiSelect field={field} />;
           case "tagger":
             return <div>tagger</div>;
           case "due_at":

src/modules/new-request-form/parent-ticket-field/ParentTicketField.tsx

@@ -4,13 +4,9 @@ interface ParentTicketFieldProps {
   field: Field;
 }
 
-export function ParentTicketField({ field }: ParentTicketFieldProps): JSX.Element {
+export function ParentTicketField({
+  field,
+}: ParentTicketFieldProps): JSX.Element {
   const { value, name } = field;
-  return (
-    <input
-      type="hidden"
-      name={name}
-      value={value}
-    />
-  );
+  return <input type="hidden" name={name} value={value} />;
 }