chore: translations for ticket fields module #551
Conversation
|
Hi @kubraokcu we moved translations for ticket fields from new request form module to separate module so the keys were changes. This was also checked already in PR's to Service Catalog feature branch but please have a second look 🙏 |
| key: "cph-theme-ticket-fields.credit-card-digits-hint" | ||
| title: "Additional label shown above the credit card field, informing the user that only the last 4 digits are required." | ||
| screenshot: "https://drive.google.com/file/d/13Pz2p5q7FHX9FKT6MUR6Sg5vWy55X0kP/view?usp=drive_link" | ||
| value: "(Last 4 digits)" |
There was a problem hiding this comment.
Didn't we have a variable for the credit card field name?
{field_name} (last 4 digits)
Here the space between the name and the suffix will be hard-coded, it's not localization-friendly for Asian and Cyrillic languages which have different space width or no space at all
There was a problem hiding this comment.
We decided to do this that way in other PR months ago here was the conversation: #474
There was a problem hiding this comment.
Ahh thank you, apologies I didn't remember about this conversation
| key: "cph-theme-ticket-fields.credit-card-digits-hint" | ||
| title: "Additional label shown above the credit card field, informing the user that only the last 4 digits are required." | ||
| screenshot: "https://drive.google.com/file/d/13Pz2p5q7FHX9FKT6MUR6Sg5vWy55X0kP/view?usp=drive_link" | ||
| value: "(Last 4 digits)" |
There was a problem hiding this comment.
Ahh thank you, apologies I didn't remember about this conversation
kubraokcu
added
g11n-approved
Description
This PR adds the source file for the translations used in the Ticket Fields module. We are using ticket fields in two modules now so we decided to separate fields from new request form. I am targeting the master branch because our internal tooling is fetching the translations from master. So, to start the translation process, we need to push the YAML file on master even if the code is still in the feature branch: https://github.com/zendesk/copenhagen_theme/tree/service-catalog-eap
Screenshots
Checklist