-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: translations for ticket fields module #551
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
# | ||
# This file is used for the internal Zendesk translation system, and it is generated from the extract-strings.mjs script. | ||
# It contains the English strings to be translated, which are used for generating the JSON files containing the translation strings | ||
# for each language. | ||
# | ||
# If you are building your own theme, you can remove this file and just load the translation JSON files, or provide | ||
# your translations with a different method. | ||
# | ||
title: "Copenhagen Theme Ticket Fields" | ||
packages: | ||
- "cph-theme-ticket-fields" | ||
parts: | ||
- translation: | ||
key: "cph-theme-ticket-fields.dropdown.empty-option" | ||
title: "[A11Y] Hidden label for screen readers, describing an empty option in a dropdown" | ||
screenshot: "https://drive.google.com/file/d/1enaOJceIEIVn_uYqvaF4AHlE1_RIpjqe/view?usp=drive_link" | ||
value: "Select an option" | ||
- translation: | ||
key: "cph-theme-ticket-fields.lookup-field.loading-options" | ||
title: "Message shown in combobox when searched options are loading" | ||
screenshot: "https://drive.google.com/file/d/1_TeqU5hihEJb03q6adVI0-nuklYask1d/view?usp=drive_link" | ||
value: "Loading items..." | ||
- translation: | ||
key: "cph-theme-ticket-fields.lookup-field.no-matches-found" | ||
title: "Message shown in combobox when searched option is not found" | ||
screenshot: "https://drive.google.com/file/d/1zwRLhFj0I0N0JV07O7wpoEZO5tBBK8JF/view?usp=drive_link" | ||
value: "No matches found" | ||
- translation: | ||
key: "cph-theme-ticket-fields.lookup-field.placeholder" | ||
title: "Placeholder shown in combobox, {{label}} will be replaced by field label. Alternative English for languages with grammar/declension issues: [Search label {{label}}]." | ||
screenshot: "https://drive.google.com/file/d/1nlnj_I-L7bkIs9Hn93Btrl8bh_HJfL6h/view?usp=drive_link" | ||
value: "Search {{label}}" | ||
- translation: | ||
key: "cph-theme-ticket-fields.credit-card-digits-hint" | ||
title: "Additional label shown above the credit card field, informing the user that only the last 4 digits are required." | ||
screenshot: "https://drive.google.com/file/d/13Pz2p5q7FHX9FKT6MUR6Sg5vWy55X0kP/view?usp=drive_link" | ||
value: "(Last 4 digits)" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't we have a variable for the credit card field name?
{field_name} (last 4 digits)
Here the space between the name and the suffix will be hard-coded, it's not localization-friendly for Asian and Cyrillic languages which have different space width or no space at all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided to do this that way in other PR months ago here was the conversation: #474
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh thank you, apologies I didn't remember about this conversation