chore(TAA-336): adding translation strings for Approval Requests #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubraokcu
reviewed
Feb 4, 2025
| value: "Status" | ||
| - translation: | ||
| key: "approval-requests.request.approval-request-details.comment" | ||
| title: "Label for the decision comment on an approval request" |
There was a problem hiding this comment.
Suggested change
| title: "Label for the decision comment on an approval request" | |
| title: "Noun - Label for the decision comment on an approval request" |
| value: "Requester" | ||
| - translation: | ||
| key: "approval-requests.list.table.sent-by" | ||
| title: "Header cell label for the sent by column of the approval requests list table" |
There was a problem hiding this comment.
Suggested change
| title: "Header cell label for the sent by column of the approval requests list table" | |
| title: "Header cell label for the sent by column of the approval requests list table - Subject: 'approval request'" |
| value: "Sent by" | ||
| - translation: | ||
| key: "approval-requests.list.table.sent-on" | ||
| title: "Header cell label for the sent on column of the approval requests list table" |
There was a problem hiding this comment.
Suggested change
| title: "Header cell label for the sent on column of the approval requests list table" | |
| title: "Header cell label for the sent on column of the approval requests list table - Subject: 'approval request'" |
| value: "Info needed" | ||
| - translation: | ||
| key: "approval-requests.status.approved" | ||
| title: "Status label for the approved status of an approval request" |
There was a problem hiding this comment.
Suggested change
| title: "Status label for the approved status of an approval request" | |
| title: "Status label for the approved status of an approval request - Subject: 'approval request'" |
| value: "Approved" | ||
| - translation: | ||
| key: "approval-requests.status.denied" | ||
| title: "Status label for the denied status of an approval request" |
There was a problem hiding this comment.
Suggested change
| title: "Status label for the denied status of an approval request" | |
| title: "Status label for the denied status of an approval request - Subject: 'approval request'" |
| value: "Denied" | ||
| - translation: | ||
| key: "approval-requests.status.withdrawn" | ||
| title: "Status label for the withdrawn status of an approval request" |
There was a problem hiding this comment.
Suggested change
| title: "Status label for the withdrawn status of an approval request" | |
| title: "Status label for the withdrawn status of an approval request - Subject: 'approval request'" |
| value: "Decided" | ||
| - translation: | ||
| key: "approval-requests.request.approval-request-details.withdrawn-on" | ||
| title: "Label for the withdrawn date on an approval request" |
There was a problem hiding this comment.
Suggested change
| title: "Label for the withdrawn date on an approval request" | |
| title: "Label for the withdrawn date on an approval request - Subject: 'approval request'" |
| value: "Sent by" | ||
| - translation: | ||
| key: "approval-requests.request.approval-request-details.sent-on" | ||
| title: "Label for the date that the approval request was submitted" |
There was a problem hiding this comment.
Suggested change
| title: "Label for the date that the approval request was submitted" | |
| title: "Label for the date that the approval request was submitted - Subject: 'approval request'" |
| value: "Approval request details" | ||
| - translation: | ||
| key: "approval-requests.request.approval-request-details.sent-by" | ||
| title: "Label for the person who submitted the approval request" |
There was a problem hiding this comment.
Suggested change
| title: "Label for the person who submitted the approval request" | |
| title: "Label for the person who submitted the approval request - Subject: 'approval request'" |
|
Thanks @kubraokcu - addressed the comments in 9bc5929 and this should be ready for re-review |
kubraokcu
reviewed
Feb 4, 2025
| value: "Status" | ||
| - translation: | ||
| key: "approval-requests.list.status-dropdown.any" | ||
| title: "Label for any dropdown option within the status dropdown on the approval requests list page" |
There was a problem hiding this comment.
Suggested change
| title: "Label for any dropdown option within the status dropdown on the approval requests list page" | |
| title: "Label for any dropdown option within the status dropdown on the approval requests list page - Subject: 'status'" |
There was a problem hiding this comment.
@KlimekM Sorry, I had to add more comments as some of the title improvements need correction + I missed one string which also need the subject info
There was a problem hiding this comment.
@kubraokcu no problem at all, updated the rest in b1da671
Also added - Subject: 'status' to two others that you didn't call out
| value: "Info needed" | ||
| - translation: | ||
| key: "approval-requests.status.approved" | ||
| title: "Status label for the approved status of an approval request - Subject: 'approval request'" |
There was a problem hiding this comment.
Suggested change
| title: "Status label for the approved status of an approval request - Subject: 'approval request'" | |
| title: "Status label for the approved status of an approval request - Subject: 'status'" |
| value: "Approved" | ||
| - translation: | ||
| key: "approval-requests.status.denied" | ||
| title: "Status label for the denied status of an approval request - Subject: 'approval request'" |
There was a problem hiding this comment.
Suggested change
| title: "Status label for the denied status of an approval request - Subject: 'approval request'" | |
| title: "Status label for the denied status of an approval request - Subject: 'status'" |
| value: "Denied" | ||
| - translation: | ||
| key: "approval-requests.status.withdrawn" | ||
| title: "Status label for the withdrawn status of an approval request - Subject: 'approval request'" |
There was a problem hiding this comment.
Suggested change
| title: "Status label for the withdrawn status of an approval request - Subject: 'approval request'" | |
| title: "Status label for the withdrawn status of an approval request - Subject: 'status'" |
…ct based on PR feedback
kubraokcu
approved these changes
Feb 5, 2025
kubraokcu
added
g11n-approved
KlimekM
deleted the
KlimekM/TAA-336-upload-approval-request-translations
branch
6 tasks
|
🎉 This PR is included in version 4.2.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the source file for the translations used in the Approval Request pages. I am opening this up separately against master so that the strings get sent off for translating.
A new folder for the approval request translations was created here: https://drive.google.com/drive/folders/1jbPTNLSXwrann-lThiz0BJU6xUgzeK6T and each of the translation keys has an attached screenshot.
Screenshots
Checklist