chore: fix approval-requests translation key and add translation #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KlimekM
commented
Feb 11, 2025
| - translation: | ||
| key: "approval-requests.list.status-dropdown.label" | ||
| title: "Label for the status dropdown on the approval requests list page" | ||
| screenshot: "https://drive.google.com/file/d/18_4fS0yROAMC1yVdDYLfYvjKWeUdWCDH/view?usp=drive_link" | ||
| value: "Status" | ||
| value: "Status:" |
There was a problem hiding this comment.
Updated here vs. creating a V2 because I did not see the keys picked up yet here: https://support.zendesk.com/rosetta/manage/translation_key_metadata?query=approval-requests.list.status-dropdown.label
But let me know if it's preferred to create the v2 string
SirishaNeduri
approved these changes
Feb 11, 2025
|
🎉 This PR is included in version 4.2.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#575 accidentally added text to a key vs. the label. This PR addresses that while also adding a translation and updating a value.
Screenshots
Checklist