Skip to content

Conversation

@Francois-Esquire
Copy link
Contributor

@Francois-Esquire Francois-Esquire commented Jul 10, 2023

Description

Use a pure CSS implementation to animate/transition height for the active Step in Stepper component. This fixes a bug found with dynamically changing heights in a Stepper.Step, since there are instances where changing the height after the Stepper.Content has been rendered does not change the height.

Detail

There is long-standing issue with animating height change that affects the web, and the implementation here makes use of grid (specifically transitioning the grid-template-rows CSS property) to handle that animation.

This treatment can be applied across the accordions package where this is relevant.

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

@coveralls
Copy link

coveralls commented Jul 10, 2023

Coverage Status

coverage: 96.23% (+0.03%) from 96.201% when pulling d9f6945 on mike/fix/stepper-dynamic-height into 13b9ac1 on main.

@Francois-Esquire Francois-Esquire marked this pull request as ready for review July 12, 2023 16:42
@Francois-Esquire Francois-Esquire requested a review from a team as a code owner July 12, 2023 16:42
Copy link
Contributor

@geotrev geotrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad this worked and love the simplicity of the approach. :shipit:

@Francois-Esquire Francois-Esquire merged commit fdbd3f9 into main Jul 12, 2023
@Francois-Esquire Francois-Esquire deleted the mike/fix/stepper-dynamic-height branch July 12, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

6 participants