fix(accordions): enable dynamic height for panel #1600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use a pure CSS implementation to animate/transition height for the expanded
Accordion.PanelinAccordioncomponent.Detail
There is long-standing issue with animating height change that affects the web, and the implementation here makes use of grid (specifically transitioning the grid-template-rows CSS property) to handle that animation.
Relates to #1570
Checklist
design updates will be Garden Designer approved (add the designer as a reviewer)yarn start)?bedrock)tested for WCAG 2.1 AA accessibility compliance