Skip to content

fix(combobox): keyboard interactions and value space rendering #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2023
Merged

fix(combobox): keyboard interactions and value space rendering #1575

merged 2 commits into from
Jul 19, 2023

Conversation

@jzempel
Copy link
Member

@jzempel jzempel commented Jul 18, 2023

Description

  • Upgrades @zendeskgarden/container-combobox with fixes detailed below
  • Update the input value HTML replacement CSS with white-space: pre to preserve user-input spaces

Detail

zendeskgarden/react-containers#552

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • ♿ tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

@jzempel jzempel requested a review from lucijanblagonic July 18, 2023 19:56
@jzempel jzempel requested a review from a team as a code owner July 18, 2023 19:56
@jzempel jzempel merged commit fb7e35d into main Jul 19, 2023
@jzempel jzempel deleted the jzempel/combobox-keyboard branch July 19, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucijanblagonic lucijanblagonic Awaiting requested review from lucijanblagonic

2 more reviewers

@geotrev geotrev geotrev approved these changes

@Francois-Esquire Francois-Esquire Francois-Esquire approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: Bug Fix 🐛

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jzempel @geotrev @Francois-Esquire @zendesk-garden