Skip to content

fix(combobox): handle select-only collapse listbox on space/enter #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2023
Merged

fix(combobox): handle select-only collapse listbox on space/enter #552

merged 1 commit into from
Jul 18, 2023

Conversation

@jzempel
Copy link
Member

@jzempel jzempel commented Jul 18, 2023

Description

For select-only (isEditable={false}) combobox:

  • Adds preventDefault to avoid page scroll when pressing keyboard space
  • Attaches same ☝️ behavior to tags for isMultiselectable
  • Adds selection on enter/space

Detail

Reference https://www.w3.org/WAI/ARIA/apg/patterns/combobox/examples/combobox-select-only/#kbd_label

Checklist

  • 🌐 demo is up-to-date (yarn start)
  • 💂‍♂️ includes new unit tests
  • ♿ tested for WCAG 2.1 AA compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

@jzempel jzempel requested a review from a team as a code owner July 18, 2023 15:24
@coveralls
Copy link

coveralls commented Jul 18, 2023

Coverage Status

coverage: 95.671%. remained the same when pulling fe62023 on jzempel/combobox-keyboard into 66ec279 on main.

geotrev
geotrev approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@geotrev geotrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jzempel jzempel merged commit 4ff0afc into main Jul 18, 2023
@jzempel jzempel deleted the jzempel/combobox-keyboard branch July 18, 2023 17:53
@jzempel jzempel mentioned this pull request Jul 18, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@geotrev geotrev geotrev approved these changes

@Francois-Esquire Francois-Esquire Francois-Esquire approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jzempel @coveralls @geotrev @Francois-Esquire @zendesk-garden