feat(colorpickers)!: refactor ColorSwatch with improved accessibility backed by a native input (radio or checkbox) group
#1711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes RTL placement for: - `top-start` - `top-end` - `bottom-start` - `bottom-end`
geotrev
approved these changes
Feb 20, 2024
|
|
||
| - `react-theming@v9` uses version range `^4.2.0 || ^5.1.0` to support `v8` to `v9` upgrades. | ||
|
|
||
| - Garden v9 upgraded from `react-merge-refs` v1 to v2. |
There was a problem hiding this comment.
Thank you for catching this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: see the
migration.mddiff for details.Description
This refactored PR uses Garden's updated
gridcontainer to handle navigation over color chips which are now backed by a native<input type="radio">group – now requiring anameprop for group association. The 🚀 newisCheckboxGroupprop can be used to convert the color swatch to a<input type="checkbox">group – which means selection can now be compeletely cleared, if necessary. The native controls naturally enhance keyboard accessibility by helping the user understand they are navigating agridgroup.Detail
The branch merge from
mainreminded me to addreact-merge-refsv2 notes to the migration guide.Checklist
npm start)?bedrock)