Skip to content

Conversation

@jzempel
Copy link
Member

@jzempel jzempel commented Apr 4, 2024

Description

Ensures a toggled button's border stacks properly within an <InputGroup>.

Detail

Before After
Screenshot 2024-04-04 at 10 02 39 AM Screenshot 2024-04-04 at 10 03 06 AM

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

@jzempel jzempel merged commit 88fe329 into main Apr 4, 2024
@jzempel jzempel deleted the jzempel/group-toggle branch April 4, 2024 14:27
@jgorfine-zendesk
Copy link
Contributor

Much obliged

jzempel added a commit that referenced this pull request Apr 4, 2024
jzempel added a commit that referenced this pull request Apr 4, 2024
* chore(deps): update non-major shared dependencies (#1765)
* chore(deps): update typescript-eslint monorepo to v7 (#1769)
* chore(deps): update dependency @storybook/addon-designs to v8 (#1766)
* chore(deps): update dependency @zendeskgarden/eslint-config to v39 (#1767)
* fix(dropdowns.next): prevent combobox `Option` and menu `Item` overflow (#1777)
* chore(deps): update non-major shared dependencies (#1772)
* fix(forms): `InputGroup` toggle button stacking (#1778)
* fix(grid): ensure `Pane.SplitterButton` is rendered as a sibling, rather than child, of `Pane.Splitter` (#1776)
* chore(changelog): add v8.75.1
@coveralls
Copy link

Coverage Status

coverage: 96.194%. remained the same
when pulling 8b41e32 on jzempel/group-toggle
into a7243dd on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

6 participants