fix(grid): ensure Pane.SplitterButton is rendered as a sibling, rather than child, of Pane.Splitter
#1776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzempel
changed the title
Pane.SplitterButton is rendered as a sibling, rather than child, of Pane.SplitterPane.SplitterButton is rendered as a sibling, rather than child, of Pane.Splitter
jzempel
added a commit
that referenced
this pull request
Apr 4, 2024
…her than child, of `Pane.Splitter` (#1776)
jzempel
added a commit
that referenced
this pull request
Apr 4, 2024
* chore(deps): update non-major shared dependencies (#1765) * chore(deps): update typescript-eslint monorepo to v7 (#1769) * chore(deps): update dependency @storybook/addon-designs to v8 (#1766) * chore(deps): update dependency @zendeskgarden/eslint-config to v39 (#1767) * fix(dropdowns.next): prevent combobox `Option` and menu `Item` overflow (#1777) * chore(deps): update non-major shared dependencies (#1772) * fix(forms): `InputGroup` toggle button stacking (#1778) * fix(grid): ensure `Pane.SplitterButton` is rendered as a sibling, rather than child, of `Pane.Splitter` (#1776) * chore(changelog): add v8.75.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the structure detailed below currently fails WCAG accessibility by violating the following:
This PR ensures that the
<Pane.SplitterButton>will be rendered as a sibling after<Pane.Splitter>rather than a child. The updated positioning logic prevents the::beforepseudo backing "dish" hack behind the transparent<ChevronButton>. As a result positioning, box-shadow, stacking, and opacity CSS was moved fromStyledPaneSplitterButtonto a new backingStyledPaneSplitterButtonContainerdiv. The result is an overall simplification of the styling structure.Detail
The JSX structure remains the same (non-breaking)
Checklist
design updates will be Garden Designer approved (add the designer as a reviewer)demo is up-to-date (npm start)?bedrock)includes new unit tests. Maintain existing coverage (always >= 96%)