fix(chrome): prevent focus on closed Sheet
#1920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ze-flo
approved these changes
Sep 11, 2024
| return ( | ||
| <SheetContext.Provider value={sheetContext}> | ||
| <StyledSheet | ||
| inert={isOpen ? undefined : ''} |
There was a problem hiding this comment.
Adding a mental note that this might break with React@19.x:
There was a problem hiding this comment.
using an empty string feels wrong anyway lol glad they're fixing it.
There was a problem hiding this comment.
the unit tests should tell us if the fix breaks Garden's code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applies
inertattribute when theSheetis closed in order to prevent tab focus through the sheet's interactive elements.Checklist
design updates will be Garden Designer approved (add the designer as a reviewer)demo is up-to-date (npm start)renders as expected with reversed (RTL) directionrenders as expected in dark moderenders as expected with Bedrock CSS (?bedrock)