Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(accordions): set inert for hidden Stepper content #1982

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented Dec 2, 2024

Description

Similar to Accordion panel and Sheet content, this PR applies the HTML inert attribute in order to prevent tab navigation through focusable elements that are rendered within hidden Stepper content sections.

Detail

Compare with #1920

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • renders as expected in dark mode
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • ♿ tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

@coveralls
Copy link

Coverage Status

coverage: 95.658% (+0.001%) from 95.657%
when pulling 8d02c2f on jzempel/inert-stepper
into 2c2c590 on main.

Copy link
Contributor

@ze-flo ze-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for referencing #1920. Looks good! 💯

@jzempel jzempel merged commit 480a7b6 into main Dec 2, 2024
9 checks passed
@jzempel jzempel deleted the jzempel/inert-stepper branch December 2, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants