-
Notifications
You must be signed in to change notification settings - Fork 48
Conversation
Added zf3 in requirements
By accepting that PR will be able to work with this package also in ZF3. |
Please, anyone can handle that PR? |
Hi @mwillbanks, could you kindly handle that pull request? |
composer.json
Outdated
@@ -21,6 +21,12 @@ | |||
"ZendServiceTest\\Google\\": "tests/" | |||
} | |||
}, | |||
"repositories": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the reasons for this extension?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done this relying on this https://github.com/zendframework/ZendService_Apple_Apns/blob/master/composer.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look at this template for Composer. (still work in progress, but already the right boilerplate)
.travis.yml
Outdated
@@ -1,5 +1,7 @@ | |||
language: php | |||
|
|||
dist: trusty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis CI failed without this...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ignore HHVM. You will find some background in this blog post: "Zend Framework and PHP 7.1"
For Travis is also a template in work: zendframework/maintainers#16
Hi @froschdesign, with the new composer.json / travis file we have new errors: Thank you! |
Hi @froschdesign, please let me know what can I do to solve the issue. |
Hi again, an other updates about the Travis CI fail: locally I could run tests with success (below the result). vendor/bin/phpunit --color=always .............................S.. Time: 46 ms, Memory: 6.00MB OK, but incomplete, skipped, or risky tests! Thank you |
Hello, I've found a way to solve the issue by removing the package from requirements, add adding it to the autoload section in composer json file.
Best regards. |
Requirements updates in order to use the package with the version 3 of the framework.