Skip to content
This repository has been archived by the owner on Dec 7, 2019. It is now read-only.

Update composer.json #33

Closed
wants to merge 7 commits into from
Closed

Update composer.json #33

wants to merge 7 commits into from

Conversation

akaneru
Copy link

@akaneru akaneru commented Jul 18, 2017

Requirements updates in order to use the package with the version 3 of the framework.

Added zf3 in requirements
@akaneru
Copy link
Author

akaneru commented Jul 18, 2017

By accepting that PR will be able to work with this package also in ZF3.
Thanks!

@akaneru
Copy link
Author

akaneru commented Jul 24, 2017

Please, anyone can handle that PR?
Thanks!

@akaneru
Copy link
Author

akaneru commented Jul 27, 2017

Hi @mwillbanks, could you kindly handle that pull request?
Thanks

composer.json Outdated
@@ -21,6 +21,12 @@
"ZendServiceTest\\Google\\": "tests/"
}
},
"repositories": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the reasons for this extension?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@froschdesign froschdesign Jul 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at this template for Composer. (still work in progress, but already the right boilerplate)

.travis.yml Outdated
@@ -1,5 +1,7 @@
language: php

dist: trusty
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis CI failed without this...

Copy link
Member

@froschdesign froschdesign Jul 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ignore HHVM. You will find some background in this blog post: "Zend Framework and PHP 7.1"

For Travis is also a template in work: zendframework/maintainers#16

@akaneru
Copy link
Author

akaneru commented Jul 31, 2017

Hi @froschdesign, with the new composer.json / travis file we have new errors:
iconv_set_encoding(): Use of iconv.internal_encoding is deprecated
That's strange because it appears to be already resolved zendframework/zf1#344 zendframework/zendframework#6218
But maybe there's something that I'm missing or I don't know :|
Could you give me some suggestion?

Thank you!

@akaneru
Copy link
Author

akaneru commented Aug 21, 2017

Hi @froschdesign, please let me know what can I do to solve the issue.
Best regards,
tomaso

@akaneru
Copy link
Author

akaneru commented Aug 28, 2017

Hi again, an other updates about the Travis CI fail: locally I could run tests with success (below the result).

vendor/bin/phpunit --color=always
PHPUnit 4.8.36 by Sebastian Bergmann and contributors.

.............................S..

Time: 46 ms, Memory: 6.00MB

OK, but incomplete, skipped, or risky tests!
Tests: 32, Assertions: 108, Skipped: 1.
`

Thank you

@akaneru
Copy link
Author

akaneru commented Aug 30, 2017

Hello, I've found a way to solve the issue by removing the package from requirements, add adding it to the autoload section in composer json file.
That allow me to update zend framework 3 and use it with the Gcm service.

{
    "require": {
        "php": "^5.6|^7.0",
        "zendframework/zendframework": "^3.0",
        "zendframework/zend-i18n": "^2.7",
        "zendframework/zend-mvc-plugin-flashmessenger": "^1.0",
        "zendframework/zendservice-apple-apns": "dev-master"
    },
    "autoload": {
        "psr-4": {
            "ZendService\\Google\\": "libraries/ZendService_Google_Gcm/library/"
        }
    }
}

Best regards.

@akaneru akaneru closed this Aug 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants