Add travis template #16

geerteltink · 2017-07-13T10:10:10Z

See #15.

This PR adds a template for Travis CI configuration to attempt to have a central location for templates and communication about possible future changes.

Currently when updating a project the way to have an up-to-date .travis.yml file is looking it up in the latest released package and copy the changes from there. This makes the example config available in a central place.

michalbundyra

Not sure but maybe we should include in that template also variables and commands to deploy documentation.

michalbundyra · 2017-07-13T10:18:15Z

template/.travis.yml

+  - if [[ $TEST_COVERAGE == 'true' ]]; then travis_retry composer require --dev $COMPOSER_ARGS $COVERAGE_DEPS ; fi
+  - stty cols 120
+  - export COLUMNS=120
+  - composer show


I would go here with:

- COLUMNS=120 composer show

instead of two above lines

Do we need both the stty cols 120 and export COLUMNS lines?

If only the stty command works, remove the export line.

If the export works, remove the stty line, and combine the export and the composer show lines as @webimpress suggests.

michalbundyra · 2017-07-13T10:19:12Z

template/.travis.yml

+cache:
+  directories:
+    - $HOME/.composer/cache
+    - $HOME/.local


Don't we need here vendor and zf-mkdoc-theme?

michalbundyra · 2017-07-13T10:20:22Z

template/.travis.yml

+  global:
+    - COMPOSER_ARGS="--no-interaction"
+    - COVERAGE_DEPS="satooshi/php-coveralls"
+    - LEGACY_DEPS="phpunit/phpunit"


What about other variables (for docs deploy)?

Since this is for new packages, I think we can ignore the LEGACY_DEPS situation entirely.

michalbundyra · 2017-07-13T10:20:32Z

template/.travis.yml

+    - php: 5.6
+      env:
+        - DEPS=locked
+        - TEST_COVERAGE=true


What about:

- DEPLOY_DOCS="$(if [[ $TRAVIS_BRANCH == 'master' && $TRAVIS_PULL_REQUEST == 'false' ]]; then echo -n 'true' ; else echo -n 'false' ; fi)"

Correct, this is missing!

weierophinney · 2017-07-13T11:06:39Z

Maybe we should include in that template also variables and commands to deploy documentation.

I'm working on having zfbot build the docs. Since the bot gets triggered for build status events, it can trigger doc builds when it detects a successful build on the master branch. Doing this means we can remove such integration out of the Travis config - which has a nice side effect of preventing token exposure (our previous token was exposed a couple months ago; github revoked it for us when it was detected). It will also make triggering new builds when templates change far easier.

geerteltink · 2017-07-13T11:11:26Z

I'm working on having zfbot build the docs. Since the bot gets triggered for build status events, it can trigger doc builds when it detects a successful build on the master branch.

Exactly why I didn't include it. And more reason to have a centralized template as others didn't know about this yet.

froschdesign · 2017-07-13T12:49:06Z

Exactly why I didn't include it.

Exactly why these boilerplates so important, because all others didn't know this!

Was used for docs generation?

geerteltink · 2017-07-16T06:16:54Z

I'm not so happy with these 2 lines:

env:
  global:
    - LEGACY_DEPS="phpunit/phpunit"

install:
  - if [[ $TRAVIS_PHP_VERSION =~ ^5.6 ]]; then travis_retry composer update $COMPOSER_ARGS --with-dependencies $LEGACY_DEPS ; fi

They are not reusable. Can't we write it like this:

matrix:
  include:
    - php: 5.6
      env:
        - DEPS=lowest
        - LEGACY_DEPS="phpunit/phpunit"

install:
  - if [[ $LEGACY_DEPS != "" ]]; then travis_retry composer update $COMPOSER_ARGS --with-dependencies $LEGACY_DEPS ; fi

This way we can reuse it for any php version where needed.

froschdesign · 2017-07-19T06:45:42Z

@xtreamwayz

This way we can reuse it for any php version where needed.

Makes sense.

michalbundyra · 2017-07-24T10:32:27Z

I think we will need to set then LEGACY_DEPS only on locked build.

weierophinney

Since this targets new packages, we can eliminate even more from the boilerplate: we don't need anything related to PHP 5.6 compat, and we can remove the 7.0 build targets as well.

weierophinney · 2017-08-01T19:40:31Z

template/.travis.yml

+  global:
+    - COMPOSER_ARGS="--no-interaction"
+    - COVERAGE_DEPS="satooshi/php-coveralls"
+    - LEGACY_DEPS="phpunit/phpunit"


Since this is for new packages, I think we can ignore the LEGACY_DEPS situation entirely.

weierophinney · 2017-08-01T19:41:19Z

template/.travis.yml

+
+matrix:
+  include:
+    - php: 5.6


For new packages, we only need 7.1 and nightly; we can remove the 5.6 and 7.0 targets (though you'll have to move the TEST_COVERAGE env stuff to the 7.1 locked env).

weierophinney · 2017-08-01T19:41:43Z

template/.travis.yml

+
+install:
+  - travis_retry composer install $COMPOSER_ARGS
+  - if [[ $TRAVIS_PHP_VERSION =~ ^5.6 ]]; then travis_retry composer update $COMPOSER_ARGS --with-dependencies $LEGACY_DEPS ; fi


This can be removed when you remove the 5.6 targets.

weierophinney · 2017-08-01T19:43:30Z

template/.travis.yml

+  - if [[ $TEST_COVERAGE == 'true' ]]; then travis_retry composer require --dev $COMPOSER_ARGS $COVERAGE_DEPS ; fi
+  - stty cols 120
+  - export COLUMNS=120
+  - composer show


Do we need both the stty cols 120 and export COLUMNS lines?

If only the stty command works, remove the export line.

If the export works, remove the stty line, and combine the export and the composer show lines as @webimpress suggests.

geerteltink · 2017-08-02T19:49:01Z

COLUMNS=120 composer show -> only shows package names
export COLUMNS=120 composer show -> doesn't show anything
export COLUMNS=120 && composer show -> only shows package names
stty cols 120 - > works
stty cols 120 && composer show -> works

For tests and travis composer show output see xtreamwayz/xtreamwayz.com#20

…iptions COLUMNS=120 doesn't seem to do anything.

weierophinney · 2017-08-02T20:10:52Z

template/.travis.yml

+    - php: 7.1
+      env:
+        - DEPS=latest
+    - php: nightly


Last change, I promise! However, I discovered today that we can now use the alias 7.2! They'll be updating it to track the betas, RCs, and then stable releases. I tested it on the zend-psr7bridge package, and it works brilliantly!

Until it's stable it should allow failures.

Add travis template

Close #16

weierophinney · 2017-08-02T20:26:51Z

Thanks, @xtreamwayz!

Add travis template

7811794

geerteltink mentioned this pull request Jul 13, 2017

Update Travis CI config zendframework/zend-expressive-fastroute#37

Merged

michalbundyra reviewed Jul 13, 2017

View reviewed changes

Remove $HOME/.local from cache

36dfb70

Was used for docs generation?

froschdesign mentioned this pull request Jul 27, 2017

Update composer.json zendframework/ZendService_Google_Gcm#33

Closed

weierophinney suggested changes Aug 1, 2017

View reviewed changes

Remove PHP 5.6/7.0 support and legacy dependencies

e04cdd7

Use stty cols 120 to display composer show package versions and descr…

6330663

…iptions COLUMNS=120 doesn't seem to do anything.

weierophinney approved these changes Aug 2, 2017

View reviewed changes

weierophinney suggested changes Aug 2, 2017

View reviewed changes

Use PHP 7.2 instead of nightly

ee1191a

Until it's stable it should allow failures.

weierophinney merged commit ee1191a into zendframework:master Aug 2, 2017

weierophinney added a commit that referenced this pull request Aug 2, 2017

Merge pull request #16 from xtreamwayz/feature/travis-template

b51a146

Add travis template

weierophinney added a commit that referenced this pull request Aug 2, 2017

Merge branch 'hotfix/16'

3ee9c4c

Close #16

geerteltink deleted the feature/travis-template branch August 3, 2017 06:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add travis template #16

Add travis template #16

geerteltink commented Jul 13, 2017

michalbundyra left a comment

michalbundyra Jul 13, 2017

weierophinney Aug 1, 2017

michalbundyra Jul 13, 2017

michalbundyra Jul 13, 2017

weierophinney Aug 1, 2017

michalbundyra Jul 13, 2017

froschdesign Jul 13, 2017 •

edited

Loading

weierophinney commented Jul 13, 2017

geerteltink commented Jul 13, 2017

froschdesign commented Jul 13, 2017

geerteltink commented Jul 16, 2017 •

edited

Loading

froschdesign commented Jul 19, 2017

michalbundyra commented Jul 24, 2017

weierophinney left a comment

weierophinney Aug 1, 2017

weierophinney Aug 1, 2017

weierophinney Aug 1, 2017

weierophinney Aug 1, 2017

geerteltink commented Aug 2, 2017

weierophinney Aug 2, 2017

weierophinney commented Aug 2, 2017

Add travis template #16

Add travis template #16

Conversation

geerteltink commented Jul 13, 2017

michalbundyra left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

froschdesign Jul 13, 2017 • edited Loading

Choose a reason for hiding this comment

weierophinney commented Jul 13, 2017

geerteltink commented Jul 13, 2017

froschdesign commented Jul 13, 2017

geerteltink commented Jul 16, 2017 • edited Loading

froschdesign commented Jul 19, 2017

michalbundyra commented Jul 24, 2017

weierophinney left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

geerteltink commented Aug 2, 2017

Choose a reason for hiding this comment

weierophinney commented Aug 2, 2017

froschdesign Jul 13, 2017 •

edited

Loading

geerteltink commented Jul 16, 2017 •

edited

Loading