Merge pull request zendframework/zendframework#5418 from AxaliaN/patch-1

Added isset check for REMOTE_ADDR

src/PhpEnvironment/RemoteAddress.php

@@ -119,7 +119,7 @@ public function getIpAddress()
     protected function getIpAddressFromProxy()
     {
         if (!$this->useProxy
-            || !in_array($_SERVER['REMOTE_ADDR'], $this->trustedProxies)
+            || (isset($_SERVER['REMOTE_ADDR']) && !in_array($_SERVER['REMOTE_ADDR'], $this->trustedProxies))
         ) {
             return false;
         }

test/PhpEnvironment/RemoteAddressTest.php

@@ -127,4 +127,27 @@ public function testGetIpAddressFromProxyFakeData()
         $_SERVER['HTTP_X_FORWARDED_FOR'] = '8.8.8.8, 10.0.0.2, 1.1.1.1, 10.0.0.1';
         $this->assertEquals('1.1.1.1', $this->remoteAddress->getIpAddress());
     }
+
+    /**
+     * Tests if an empty string is returned if the server variable
+     * REMOTE_ADDR is not set.
+     *
+     * This happens when you run a local unit test, or a PHP script with
+     * PHP from the command line.
+     */
+    public function testGetIpAddressReturnsEmptyStringOnNoRemoteAddr()
+    {
+        // Store the set IP address for later use
+        if (isset($_SERVER['REMOTE_ADDR'])) {
+            $ipAddress = $_SERVER['REMOTE_ADDR'];
+            unset($_SERVER['REMOTE_ADDR']);
+        }
+
+        $this->remoteAddress->setUseProxy(true);
+        $this->assertEquals('', $this->remoteAddress->getIpAddress());
+
+        if (isset($ipAddress)) {
+            $_SERVER['REMOTE_ADDR'] = $ipAddress;
+        }
+    }
 }