This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Allow the usage of "Expires: 0" header #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public function setDate($date) | ||
| { | ||
| if ($date === '0') { |
There was a problem hiding this comment.
Should this also allow an integer 0 value?
There was a problem hiding this comment.
I think this is reasonable. Just updated the PR.
weierophinney
suggested changes
Jan 25, 2017
weierophinney
approved these changes
Jan 25, 2017
weierophinney
added a commit
that referenced
this pull request
Jan 25, 2017
Allow the usage of "Expires: 0" header
weierophinney
added a commit
that referenced
this pull request
Jan 25, 2017
weierophinney
added a commit
that referenced
this pull request
Jan 25, 2017
weierophinney
added a commit
that referenced
this pull request
Jan 25, 2017
Forward port #107 Conflicts: CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #103, allowing
Expires: 0header. I used the timestamp 0 that is equivalent to "Thu, 01 Jan 1970 00:00:00 GMT".