This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
More aliases, fewer factories #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Aliases typically need to be in each of: - lowercase - camelCase - TitleCase - Factories mapping to the `InvokableFactory` *must* be FQCNs *only*. The normalized version used in v2 (stripping special characters and lowercasing) will likely never be used to retrieve a service, and can be skipped.
|
This improves on #8, which has already been merged. |
|
Ping @ezimuel . |
For alias lookup to factories, the alias target name is canonicalized in order to do the lookup, though the denormalized alias target name is passed as the requested name. As a result, we need to provide factory mappings of the canonicalized name => invokable factory.
|
@ezimuel Okay, works now! We need to update the migration wiki page to indicate that:
|
|
@weierophinney Ok, I just updated the ZF3 Wiki migration page - phase 2 with all the aliases and InvokableFactory to check. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InvokableFactorymust be FQCNs only. The normalized version used in v2 (stripping special characters and lowercasing) will likely never be used to retrieve a service, and can be skipped.