This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Service Manager V2/V3 compatibility #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Adapter\PythonPickle::class => InvokableFactory::class, | ||
| 'zendserializeradapterpythonpickle' => InvokableFactory::class, | ||
| Adapter\Wddx::class => InvokableFactory::class, | ||
| 'zendserializeradapterwddx' => InvokableFactory::class |
There was a problem hiding this comment.
@weierophinney @ezimuel Is that really the way to go ?
There was a problem hiding this comment.
No. You should have a combination of aliases and factories. InvokableFactory will not work with the above aliases; it assumes the requested name is the class name. What you should do is:
- map each FCQN for a plugin to an
InvokableFactory - map aliases for each plugin to the FQCN. Typically, you'll have multiple variants, but typically all will be in short form. You don't have to do normalized versions of the FQCN as you did above.
There was a problem hiding this comment.
ezimuel
added a commit
that referenced
this pull request
Jan 19, 2016
Service Manager V2/V3 compatibility
|
@marc-mabe thanks! |
weierophinney
added a commit
to weierophinney/zend-i18n
that referenced
this pull request
Jan 20, 2016
Adds the pattern used in zendframework/zend-serializer#8 for determining which version of each library to use when testing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This component is a
require-devfor zend-cache - see zendframework/zend-cache#64