Optimize PHP function calls

[smuggli]

Those optimizations target improving OPCODES.

[smuggli]

Here are two showcases which demonstrate the optimazations.

is_string:
https://3v4l.org/sSjcd/vld#output
https://3v4l.org/Ufg8r/vld#output

array_keys:
https://3v4l.org/S8Bse/vld#output
https://3v4l.org/qRcHaJ/vld#output

I ran the PHPBench scripts but I am not sure if the report is necessary for that.

Also such optimazations already have been made:
https://github.com/zendframework/zend-servicemanager/blob/master/src/ServiceManager.php#L395
https://github.com/zendframework/zend-servicemanager/blob/master/src/ServiceManager.php#L396

[snapshotpl]

Run PHPBench scripts to show performance improvement

[smuggli]

The reports overall vary a bit, some are better and some worse.
before.txt
optimized.txt

[Ocramius]

Could you replace those isset() checks with ?? overall? Also, variadics may help too in private API

[smuggli]

@Ocramius Yes, I can replace them but this implies that support for PHP < 7 would be dropped. Has this been decided yet? For variadics I will see what I can do. Thanks for the comment.

[MichaelGooden]

@smuggli The plan moving forward is to start pinning major components against PHP 7.1.

Source: https://framework.zend.com/blog/2017-06-06-zf-php-7-1.html

[stefanotorresi]

Honestly, I don't find the performance argument very compelling.
This is a change that would need to be propagated on every ZF component for consistency, and it would also be appropriate to put a coding standards rule in place.
Is it all truly worth it?

[Ocramius]

This is generally about internal language optimisations coming up later on: the engine will optimise more of these, but only if the FQN is used.

…

On 5 Jul 2017 10:25, "Stefano Torresi" ***@***.***> wrote: Honestly, I don't find the performance argument very compelling. This is a change that would need to be propagated on every component for consistency, and it would also be appropriate to put a coding standards rule in place. Is it all truly worth it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#196 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakNTNanxREU3ivAReYrKtZ8v4dCY-ks5sK0h_gaJpZM4ONS77> .

[smuggli]

@MichaelGooden Thanks completely missed that.

@stefanotorresi It is not a big gain but still something. For now I just started with ServiceManager to see if changes like that are welcome ;). Haven't made any thoughts on a coding standard rule yet.

@Ocramius Just replaced the issets with ?? for now because I am running out of time for today.

[michalbundyra]

@smuggli This PR should target develop, not master.

[smuggli]

@webimpress Changed it to develop. Thanks!

[michalbundyra]

@smuggli I've created separate PR to drop PHP 5.6 and 7.0 support - #197. I will work on PHPCS sniff (in zend-coding-standard library) to detect function calls without \. It shouldn't be complicated.

[Ocramius]

commit smuggli/zend-servicemanager@fc81dee is unrelated, and the patch needs to be rebased to get rid of it

[kynx]

Would use function array_key_exists achieve the same thing? It would avoid 100s of lines of code changes and be much easier on the eyes ;) Though maybe harder to sniff.

[MichaelGooden]

@kynx It does appear to achieve the same outcome:

With use function statement: https://3v4l.org/QeVpj/vld#output
Without: https://3v4l.org/sSjcd/vld#output

[Ocramius]

@kynx nice one!

[kynx]

Cheers @Ocramius !

On a side note I just found out PHPStorm can auto-import from global scope. Nice!

[michalbundyra]

Here is my sniff to import all used internal functions:
zendframework/zend-coding-standard@19e353b

I've created PR #198 after applying the sniff on develop branch.

Should we do the same with constants?
https://3v4l.org/Hlh9d/vld#output
https://3v4l.org/uSN1i/vld#output

[Ocramius]

Should we do the same with constants?

I don't think that we use many internal constants except for:

• exceptions
• filesystem-related operations
• array_map operations

All of the above are usually improved by reducing the operation amount itself, rather than these micro-optimisations...

[smuggli]

@Ocramius Sorry had no time working on that. To keep it simple, I would not do any variadics changes yet. Anything else what should be done before merging?

[Ocramius]

@smuggli this is good to go as-is, thanks!