This repository has been archived by the owner on Feb 6, 2020. It is now read-only.
Drop PHP 5.6 and 7.0 #197
Merged
Drop PHP 5.6 and 7.0 #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added nightly test
removed duplicate allow_failures
Updated packages in composer to latest stable version and PHP requirements changed to PHP ^7.1 Updated suggestion in composer.
These methods are not static.
Ocramius
suggested changes
Jul 5, 2017
| @@ -184,8 +184,8 @@ public function testExceptsWhenConfigNotSet() | |||
| { | |||
| $abstractFactory = new ConfigAbstractFactory(); | |||
| $serviceManager = new ServiceManager(); | |||
| self::expectException(ServiceNotCreatedException::class); | |||
| self::expectExceptionMessage('Cannot find a config array in the container'); | |||
| $this->expectException(ServiceNotCreatedException::class); | |||
There was a problem hiding this comment.
Why? Methods expectException* are not static. Please see:
https://github.com/sebastianbergmann/phpunit/blob/master/src/Framework/TestCase.php#L569
There was a problem hiding this comment.
Oh, totally misread this, sorry :-\
Ocramius
approved these changes
Jul 5, 2017
|
LGTM, thanks @webimpress! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropped PHP 5.6 and 7.0 support.
PR based on #195. It should be merged before #196, because #196 contains changes which requires PHP 7.
Ping @Ocramius