This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Test for ensuring, that the PhpRenderer doesnt use previous rendered output #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The php renderer was only catching Exception - PHP 7 changed how error are reported http://php.net/manual/en/language.errors.php7.php
…en the doctype is Xhtml
…l isValid() in HeadMeta::setCharset() before set()
…k-navigation Added navigation helpers in DocBlock of navigation proxy helper for code completion
…lper has translator already
spelling fixes
Closing parentheses of the attach method parameters
PHP 7 - Php Renderer - Catching Error - Bug fix
add missing Greater-than sign
Test for ensuring, that the PhpRenderer doesnt use previous rendered output
Pointing to originally reported issue.
This one-liner resets the `$__content` value prior to the render loop to ensure a cached result is not returned in the off chance that `$template` is a falsy value.
|
@porebskk I've pushed a commit that fixes the issue, but need to wait for Travis to run the tests before merging. Thanks for the excellent unit tests! |
Not sure why this wasn't flagged until now...
weierophinney
added a commit
that referenced
this pull request
Jan 17, 2018
|
Thanks, @porebskk, for the great unit test! I pushed the fix to your branch, and it has now been verified with continuous integration; I will release it soon with version 2.9.1. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue #120