This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Feature/render listener #2959
Merged
Feature/render listener #2959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch exceptions thrown when EVENT_RENDER is triggered, clean up all output, trigger EVENT_DISPATCH_ERROR, and finally re-trigger EVENT_RENDER
…feature/render-listener
… DefaultRenderingStrategy - For symmetry with DispatchListener and RouteListener, moved the exception handling out of Application and into Zend\Mvc\View\Http\DefaultRenderingStrategy. - Reviewed Zend\Mvc\View\Console\DefaultRenderingStrategy to see if exception handling was necessary; it wasn't, but cleaned up a few CS issues in the process.
- Test now had an expectation that was no longer necessary: that the output would continue to be captured and present. Since the PhpRenderer now catches exceptions and re-throws, the output buffering is handled slightly differently in exceptional circumstances.
…arate interface - Cannot add methods to existing interfaces; breaks BC - Created ClearableModelInterface with clearChildren(), and also added clearVariables() and clearOptions(). - ViewModel implements ModelInterface and ClearableModelInterface. - InjectViewModelListener now tests for ClearableModelInterface before attempting to clearChildren()
|
Reviewed code - looks sane and unit tests pass here too. |
|
I've created a custom form and am trying to render it into a view. However, the form has a bug inside it. DefaultRenderingStrategy::render() is catching it on line 131 and my app subsequently whitescreens and I cannot understand why. Is it related to this merge? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request builds on #2812, which is intended as a solution for #2528. The idea is to allow catching renderer exceptions, and triggering an additional event when one is detected.
The main differences between this PR and #2812 are: